core: checking keymanager address #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2795 +/- ##
==========================================
- Coverage 53.26% 53.25% -0.01%
==========================================
Files 199 199
Lines 27603 27616 +13
==========================================
+ Hits 14703 14708 +5
- Misses 11079 11084 +5
- Partials 1821 1824 +3 ☔ View full report in Codecov by Sentry. |
gsora
approved these changes
Jan 17, 2024
| if addr != "" && authToken == "" { | ||
| return errors.New("--keymanager-address provided but --keymanager-auth-token absent. Please fix configuration flags") | ||
| } | ||
| if addr == "" && authToken != "" { | ||
| return errors.New("--keymanager-auth-token provided but --keymanager-address absent. Please fix configuration flags") | ||
| } | ||
|
|
||
| keymanagerURL, err := url.Parse(addr) |
There was a problem hiding this comment.
Should we use url.ParseRequestURI instead? So we're 100% sure addr is a HTTP, absolute URI.
4 tasks
OisinKyne
approved these changes
Jan 17, 2024
pinebit
added
the
merge when ready
gsora
pushed a commit
that referenced
this pull request
Jan 24, 2024
Checking keymanager address. category: misc ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking keymanager address.
category: misc
ticket: none