Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect dns opcode range 5446 v2 #9929

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5446

Describe changes:

  • make keyword dns.opcode use helper for integers so that they can have all features such as range
  • integer keywords now accept negated range

#9925 with second commit

@jasonish
Copy link
Member

Should probably have a documentation update as well.

@catenacyber
Copy link
Contributor Author

Should probably have a documentation update as well.

Do you mean a generic documentation for all integer keywords ?
cc @jufajardini

@jasonish
Copy link
Member

Should probably have a documentation update as well.

Do you mean a generic documentation for all integer keywords ? cc @jufajardini

Not really, more just an update to https://docs.suricata.io/en/latest/rules/dns-keywords.html#dns-opcode, and I guess some S-V tests.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 16812

@catenacyber
Copy link
Contributor Author

Not really, more just an update to https://docs.suricata.io/en/latest/rules/dns-keywords.html#dns-opcode

Done in #9945

@catenacyber catenacyber closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants