Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect: dns.opcode as first-class integer #9925

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5446

Describe changes:

  • make keyword dns.opcode use helper for integers so that they can have all features such as range

Ticket: 5446

That means it can accept ranges
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #9925 (5dbe910) into master (9c3ab36) will increase coverage by 0.02%.
The diff coverage is 98.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9925      +/-   ##
==========================================
+ Coverage   82.35%   82.37%   +0.02%     
==========================================
  Files         972      972              
  Lines      273060   273022      -38     
==========================================
+ Hits       224870   224902      +32     
+ Misses      48190    48120      -70     
Flag Coverage Δ
fuzzcorpus 64.22% <75.00%> (+0.07%) ⬆️
suricata-verify 61.04% <75.00%> (-0.05%) ⬇️
unittests 62.91% <88.13%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

This was referenced Nov 30, 2023
@catenacyber
Copy link
Contributor Author

Replaced by #9929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant