Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect dns opcode range 5446 v3 #9945

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5446

Describe changes:

  • make keyword dns.opcode use helper for integers so that they can have all features such as range
  • integer keywords now accept negated range

#9929 with doc updated a bit

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #9945 (4a49352) into master (9c3ab36) will decrease coverage by 0.04%.
The diff coverage is 95.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9945      +/-   ##
==========================================
- Coverage   82.35%   82.31%   -0.04%     
==========================================
  Files         972      972              
  Lines      273060   273046      -14     
==========================================
- Hits       224870   224763     -107     
- Misses      48190    48283      +93     
Flag Coverage Δ
fuzzcorpus 64.10% <70.00%> (-0.05%) ⬇️
suricata-verify 61.05% <70.00%> (-0.05%) ⬇️
unittests 62.92% <87.95%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 16831

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Needs a rebase though.

@catenacyber
Copy link
Contributor Author

Does the first commit deserve its own ticket ?

@catenacyber
Copy link
Contributor Author

Rebased in #10073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants