Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] crm_claim #316

Merged
merged 12 commits into from
Jun 18, 2020
Merged

[13.0][MIG] crm_claim #316

merged 12 commits into from
Jun 18, 2020

Conversation

flachica
Copy link
Contributor

@flachica flachica commented Apr 4, 2020

In substitution of #315 for not having done squash which substitutes #311 for having conflicts

This was referenced Apr 4, 2020
Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this commit history cleansing is low value bike shedding.
But that's me, so follow the crowd.

@traviswaelbro
Copy link
Contributor

IMO this commit history cleansing is low value bike shedding.
But that's me, so follow the crowd.

This PR is 21 commits, nearly half of which are readme/translation commits. I think it's worth an extra 5 minutes to keep a cleaner commit history (and in this case have nearly half as many commits as otherwise).

Copy link
Member

@mamcode mamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Fernando, Thanks for this work, looks good to me, only I see necessary a minor change...

mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/12.0/crm_claim>`_ project on GitHub.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change URL to 13.0. I think that you should regenerate the README for this and also the list of collaborators will also be updated... You can also not send the readme and I think the bot will generate it automatically when merging the branches.

@mamcode
Copy link
Member

mamcode commented Jun 13, 2020

This PR is 21 commits, nearly half of which are readme/translation commits. I think it's worth an extra 5 minutes to keep a cleaner commit history (and in this case have nearly half as many commits as otherwise).

+1

@flachica flachica force-pushed the 13.0-mig-crm_claim branch from 38ef5f7 to 2bd84d1 Compare June 13, 2020 08:57
@flachica
Copy link
Contributor Author

@traviswaelbro @mamcode History rewrited, minor change pushed. I think that readme is regenerated on merge with 13.0 but I does this. I think as @dreispt, rewrite history is low value but I follow the crowd too

@simahawk
Copy link
Contributor

/ocabot merge nobump

@simahawk
Copy link
Contributor

@flachica next time please keep module name in migration commit, thanks (more important than rewriting history IMO) 😉

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-316-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 18, 2020
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-316-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 845bcec into OCA:13.0 Jun 18, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f0c6243. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.