-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] crm_claim #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this commit history cleansing is low value bike shedding.
But that's me, so follow the crowd.
This PR is 21 commits, nearly half of which are readme/translation commits. I think it's worth an extra 5 minutes to keep a cleaner commit history (and in this case have nearly half as many commits as otherwise). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Fernando, Thanks for this work, looks good to me, only I see necessary a minor change...
crm_claim/README.rst
Outdated
mission is to support the collaborative development of Odoo features and | ||
promote its widespread use. | ||
|
||
This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/12.0/crm_claim>`_ project on GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change URL to 13.0. I think that you should regenerate the README for this and also the list of collaborators will also be updated... You can also not send the readme and I think the bot will generate it automatically when merging the branches.
+1 |
Include record rule for multi-company.
38ef5f7
to
2bd84d1
Compare
@traviswaelbro @mamcode History rewrited, minor change pushed. I think that readme is regenerated on merge with 13.0 but I does this. I think as @dreispt, rewrite history is low value but I follow the crowd too |
/ocabot merge nobump |
@flachica next time please keep module name in migration commit, thanks (more important than rewriting history IMO) 😉 |
What a great day to merge this nice PR. Let's do it! |
It looks like something changed on |
Congratulations, your PR was merged at f0c6243. Thanks a lot for contributing to OCA. ❤️ |
In substitution of #315 for not having done squash which substitutes #311 for having conflicts