Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] crm_claim_type: Migration to 13.0 #339

Merged
merged 15 commits into from
Jul 1, 2020

Conversation

mamcode
Copy link
Member

@mamcode mamcode commented Jun 13, 2020

This depends on #316

@mamcode mamcode mentioned this pull request Jun 13, 2020
17 tasks
@simahawk simahawk added this to the 13.0 milestone Jun 18, 2020
@mamcode mamcode force-pushed the 13.0-mig-crm_claim_type branch from d08c83d to f5acbc9 Compare June 18, 2020 10:47
@mamcode
Copy link
Member Author

mamcode commented Jun 18, 2020

@simahawk Fixed, please give me a review :)

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM 👍

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, some small remarks.

@mamcode mamcode force-pushed the 13.0-mig-crm_claim_type branch from 042070b to f10e506 Compare June 20, 2020 14:12
@mamcode mamcode force-pushed the 13.0-mig-crm_claim_type branch from f10e506 to 03e5966 Compare June 20, 2020 20:21
Copy link

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@simahawk
Copy link
Contributor

simahawk commented Jul 1, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-339-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 9448476 into OCA:13.0 Jul 1, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bda117f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.