[13.0][MIG] mig_crm_claim: Migration to 13.0 #307
Conversation
|
@manuelcalerosolis Please fix runbot warnings |
manuelcalerosolis
force-pushed
the
13.0-mig-crm_claim
branch
from
5feba4b to
cf1b576
Compare
manuelcalerosolis
requested review from
pedrobaeza,
ernestotejeda and
chienandalu
|
Please squash migration commits and administrative commits |
There was a problem hiding this comment.
Thank you @manuelcalerosolis, Just some suggestions
You can generate README.rst using OCA/maintainer-tools
There was a problem hiding this comment.
👍 Looks good in general. One nag. And please squash commits as suggested by @pedrobaeza
manuelcalerosolis
force-pushed
the
13.0-mig-crm_claim
branch
8 times, most recently
from
93f2c71 to
6f711d7
Compare
manuelcalerosolis
force-pushed
the
13.0-mig-crm_claim
branch
from
6f711d7 to
e4b5945
Compare
Include record rule for multi-company.
Currently translated at 10.5% (15 of 143 strings) Translation: crm-12.0/crm-12.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_claim/hr/
Currently translated at 100.0% (143 of 143 strings) Translation: crm-12.0/crm-12.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_claim/es/
manuelcalerosolis
force-pushed
the
13.0-mig-crm_claim
branch
from
e4b5945 to
487386b
Compare
|
|
||
| from psycopg2.extensions import AsIs | ||
| # pylint: disable=sql-injection |
There was a problem hiding this comment.
Is this necessary?
Why not to avoid psycopg2 formatters and use a report style like Odoo does: https://github.com/odoo/odoo/blob/13.0/addons/sale/report/sale_report.py#L61
There was a problem hiding this comment.
@yajo and I, we were looking at several ways to solve it, he recommended that I use that directive.
There was a problem hiding this comment.
Indeed much better @chienandalu, thanks for the tip.
|
Merged in #316 |
This is the migration mig_crm_claim to 13.0 version
@Tecnativa TT22081