firebase tools: 13.30.0 -> 13.31.2 #382118

sarahec · 2025-02-14T19:13:30Z

Replaced by #386207

13.30.0 -> 13.31.2

Switched Data Connect from v1beta API to v1 API.
Added code generation of React hooks for Data Connect
Genkit init improvements around gcloud login and flow input values.
Added new command apps:init under experimental flag (appsinit) that automatically detects what SDK to download and places the file in the corresponding place.
Removed dependencies on some packages and methods that caused deprecation warnings on Node 22.
Fixes symbol generation when uploading Unity 6 symbols to Crashlytics. (Breakpad symbol generation failed for Unity 6 symbols firebase/firebase-tools#7867)
Fixed SSR issues in Angular 19 by adding support for default and reqHandler exports. (fix: support default and reqHandler exports in Angular firebase/firebase-tools#8145)
Added Angular 19 as supported version. (fix: support default and reqHandler exports in Angular firebase/firebase-tools#8145)
Fixed appdistribution:testers:list raising an error when a tester is not part of any group. (Error on firebase appdistribution:testers:list firebase/firebase-tools#8191)
Updated the Firebase Data Connect local toolkit to v1.8.0, which includes several changes: (Bump FDC local toolkit to v1.8.0. firebase/firebase-tools#8210)
- Adds support for the v1 Data Connect API in the emulator
- Adds support for generated React SDKs
- Fixes @check to also be evaluated for admin auth
- Fixes CEL expressions to be able to access @redact fields
- Fixed issue where firebase init dataconnect would crash on React-based web apps.
Updated the Firebase Data Connect local toolkit to v.1.8.1, which:
- Fixed issue where users who are using a version lower than 11.3.0 of firebase get a "missing import" error.

Enabled auto-updates via passthru.updateScript

Things done

Add a 👍 reaction to pull requests you find important.

momeemt · 2025-02-15T12:51:31Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382118

`aarch64-darwin`

❌ 1 package failed to build:

firebase-tools

momeemt

It failed to build by the following error even though linking package-lock.json in postPatch, I'll look into the cause.

❯ nix-build -A firebase-tools
this derivation will be built:
  /nix/store/ks3yf0x7jgljpwd86rylxl62iy8sbcf5-firebase-tools-13.31.1.drv
building '/nix/store/ks3yf0x7jgljpwd86rylxl62iy8sbcf5-firebase-tools-13.31.1.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/6m5h6142z34fmwan06sg5vfq0s9nib3i-source
source root is source
Running phase: patchPhase
Executing npmConfigHook
Configuring npm
Validating consistency between /private/tmp/nix-build-firebase-tools-13.31.1.drv-0/source/package-lock.json and /nix/store/ynq87csgm3k1ay9gw6m9yjirp56h70f6-firebase-tools-13.31.1-npm-deps/package-lock.json
Fixing lockfile
\Installing dependencies
npm error code ENOTCACHED
npm error request to https://registry.npmjs.org/ajv-formats failed: cache mode is 'only-if-cached' but no cached response is available.
npm error Log files were not written due to an error writing to the directory: /nix/store/ynq87csgm3k1ay9gw6m9yjirp56h70f6-firebase-tools-13.31.1-npm-deps/_logs
npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal

ERROR: npm failed to install dependencies

Here are a few things you can try, depending on the error:
1. Set `makeCacheWritable = true`
  Note that this won't help if npm is complaining about not being able to write to the logs directory -- look above that for the actual error.
2. Set `npmFlags = [ "--legacy-peer-deps" ]`

error: builder for '/nix/store/ks3yf0x7jgljpwd86rylxl62iy8sbcf5-firebase-tools-13.31.1.drv' failed with exit code 1;
       last 10 log lines:
       > npm error Log files were not written due to an error writing to the directory: /nix/store/ynq87csgm3k1ay9gw6m9yjirp56h70f6-firebase-tools-13.31.1-npm-deps/_logs
       > npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal
       >
       > ERROR: npm failed to install dependencies
       >
       > Here are a few things you can try, depending on the error:
       > 1. Set `makeCacheWritable = true`
       >   Note that this won't help if npm is complaining about not being able to write to the logs directory -- look above that for the actual error.
       > 2. Set `npmFlags = [ "--legacy-peer-deps" ]`
       >
       For full logs, run 'nix-store -l /nix/store/ks3yf0x7jgljpwd86rylxl62iy8sbcf5-firebase-tools-13.31.1.drv'.

pkgs/by-name/fi/firebase-tools/package.nix

sarahec

This is unnecessary, r-ryantm can handle updates without an explicit update script.

Thank you, I'll drop this change.

sarahec · 2025-02-15T22:33:39Z

It failed to build by the following error even though linking package-lock.json in postPatch, I'll look into the cause.

Well, nuts. It worked for me yesterday but not today. Thank you for looking into this.

aspauldingcode · 2025-02-19T22:06:31Z

Hi @sarahec, I see I am requested for review.
How do I do this?

sarahec · 2025-02-20T03:36:16Z

Hi @sarahec, I see I am requested for review. How do I do this?

That request was by accident, this picked up an unrelated code-cursor change that I then fixed.

vkryachko · 2025-02-21T20:01:40Z

Upon some review, I've noticed that firebase-tools updated their package.json in the following way:

https://github.com/firebase/firebase-tools/blob/dad1b1a23daaed226ca6dde257c4fcf14acbb4f3/package.json#L260-L268

This resulted in their lock file to contain entries that don't seem to be supported by fetchNpmDeps, the lock file ended up like this:

Notice how the link moved into the version. I am not sure why this was reflected in the lock file this way, but it looks like npm does it this way.

I tried running this jq in postPatch:

jq '.packages |= map_values(
      if (. | type) == "object" and (.dependencies | type) == "object" then
        .dependencies |= map_values(
          if (. | type) == "object" and (.version | startswith("https"))
          then 
            .resolved = .version | .version |= capture(".*-(?<version>[^-]+)\\.tgz").version
          else 
            .
          end
        )
      else . end)' npm-shrinkwrap.json | sponge npm-shrinkwrap.json

But it did not fix the problem. Any ideas on how to overcome this?

joehan · 2025-02-21T20:36:51Z

firebase-tools maintainer here - chiming in to keep an eye on this and help out if needed.

The shrinkwrap changes that @vkryachko mentioned were a result of adding overrides for ajv and ajv-format (https://github.com/firebase/firebase-tools/blob/master/package.json#L261).

sarahec · 2025-02-25T03:52:58Z

@joehan could you review firebase/firebase-tools#8253 ? If it looks good, I can fettchpatch or bump this to the release containing it.

vkryachko · 2025-02-25T15:12:03Z

@joehan could you review firebase/firebase-tools#8253 ? If it looks good, I can fettchpatch or bump this to the release containing it.

Hi @sarahec , thanks for taking a look at this issue. I am wondering how have you arrived at this patch? Was it a manual change? if not, would be very interested to know how you did it and not recreating the lock file from scratch :)

Also running npm i on your change results in this diff, worth including?

--- a/npm-shrinkwrap.json
+++ b/npm-shrinkwrap.json
@@ -21059,6 +21059,8 @@
           "integrity": "sha512-hTdwr+7yYNIT5n4AMYp85KA6yw2Va0FLa3Rguvbpa4W3I5x>
           "dev": true,
           "requires": {
+            "ajv": "^8.17.1",
+            "ajv-formats": "3.0.1",
             "tslib": "^1.9.0"
           }
         },
@@ -24875,7 +24877,7 @@
       "resolved": "https://registry.npmjs.org/ajv-formats/-/ajv-formats-3.0.1.>
       "integrity": "sha512-8iUql50EUR+uUcdRQ3HDqa6EVyo3docL8g5WJ3FNcWmu62IbkGU>
       "requires": {
-        "ajv": "^8.0.0"
+        "ajv": "^8.17.1"
       }
     },
     "ansi-align": {

joehan · 2025-02-25T19:04:38Z

Thanks for the contribution @sarahec - I did some testing on it this morning and it looks good to me. I ran npm i to stabilize npm-shirnkwrap (required for our CI), and merged the change. This would be included in the next release of firebase-tools sometime later this week.

sarahec · 2025-02-25T19:07:41Z

@vkryachko I applied this as a manual change. The shrinkwrap has many such changes due to the age of some of its components. @joehan just integrated your suggestion upstream, so we'll wait for that.

@joehan thank you. I'll await the release later this week and bump this patch one last time.

sarahec · 2025-03-01T00:21:48Z

@joehan Thanks for all your help upstream. It's time to put this to bed.

sarahec · 2025-03-01T20:45:14Z

Replaced by #386207

sarahec force-pushed the firebase-tools-13-31-1 branch from b486477 to 8780ae6 Compare February 14, 2025 19:16

github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 14, 2025

nix-owners bot requested review from aspauldingcode and momeemt February 14, 2025 19:21

github-actions bot added 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Feb 14, 2025

momeemt suggested changes Feb 15, 2025

View reviewed changes

NickCao reviewed Feb 15, 2025

View reviewed changes

pkgs/by-name/fi/firebase-tools/package.nix Outdated Show resolved Hide resolved

sarahec commented Feb 15, 2025

View reviewed changes

sarahec force-pushed the firebase-tools-13-31-1 branch from 8780ae6 to b8fcb0c Compare February 15, 2025 22:24

sarahec force-pushed the firebase-tools-13-31-1 branch from b8fcb0c to 317ed81 Compare February 19, 2025 19:58

sarahec mentioned this pull request Feb 25, 2025

Overrides not propagated into npm-shrinkwrap, causes nix build to fail firebase/firebase-tools#8252

Closed

sarahec force-pushed the firebase-tools-13-31-1 branch 2 times, most recently from 550efa5 to d15f92c Compare February 25, 2025 03:37

sarahec changed the title ~~firebase tools: 13.30.0 -> 13.31.1~~ firebase tools: 13.30.0 -> 13.31.2 Feb 25, 2025

sarahec force-pushed the firebase-tools-13-31-1 branch from d15f92c to 54509d8 Compare March 1, 2025 00:20

sarahec requested review from momeemt and NickCao March 1, 2025 00:23

firebase-tools: 13.30.0 -> 13.32.0

68fbe42

sarahec force-pushed the firebase-tools-13-31-1 branch from 54509d8 to 68fbe42 Compare March 1, 2025 20:44

sarahec mentioned this pull request Mar 1, 2025

firebase-tools: 13.30.0 -> 13.32.0 #386207

Merged

13 tasks

sarahec closed this Mar 1, 2025

sarahec deleted the firebase-tools-13-31-1 branch March 1, 2025 21:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

firebase tools: 13.30.0 -> 13.31.2 #382118

firebase tools: 13.30.0 -> 13.31.2 #382118

sarahec commented Feb 14, 2025 •

edited

Loading

momeemt commented Feb 15, 2025

momeemt left a comment

sarahec left a comment

sarahec commented Feb 15, 2025 •

edited

Loading

aspauldingcode commented Feb 19, 2025

sarahec commented Feb 20, 2025

vkryachko commented Feb 21, 2025

joehan commented Feb 21, 2025

sarahec commented Feb 25, 2025

vkryachko commented Feb 25, 2025

joehan commented Feb 25, 2025

sarahec commented Feb 25, 2025 •

edited

Loading

sarahec commented Mar 1, 2025

sarahec commented Mar 1, 2025

firebase tools: 13.30.0 -> 13.31.2 #382118

firebase tools: 13.30.0 -> 13.31.2 #382118

Conversation

sarahec commented Feb 14, 2025 • edited Loading

Replaced by #386207

13.30.0 -> 13.31.2

Things done

momeemt commented Feb 15, 2025

nixpkgs-review result

aarch64-darwin

momeemt left a comment

Choose a reason for hiding this comment

sarahec left a comment

Choose a reason for hiding this comment

sarahec commented Feb 15, 2025 • edited Loading

aspauldingcode commented Feb 19, 2025

sarahec commented Feb 20, 2025

vkryachko commented Feb 21, 2025

joehan commented Feb 21, 2025

sarahec commented Feb 25, 2025

vkryachko commented Feb 25, 2025

joehan commented Feb 25, 2025

sarahec commented Feb 25, 2025 • edited Loading

sarahec commented Mar 1, 2025

sarahec commented Mar 1, 2025

sarahec commented Feb 14, 2025 •

edited

Loading

`nixpkgs-review` result

`aarch64-darwin`

sarahec commented Feb 15, 2025 •

edited

Loading

sarahec commented Feb 25, 2025 •

edited

Loading