Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase-tools: 13.30.0 -> 13.32.0 #386207

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

sarahec
Copy link
Contributor

@sarahec sarahec commented Mar 1, 2025

via update script

v13.32.0 Latest

  • Replaced VSCODE_CWD check to address issues running in VSCode environments. (Enable some libs on Darwin #7471)
  • Added initial delay when loading python functions (Atom: updated to 0.207.0 #8239)
  • Enforced webframeworks enablement only on webframeworks sites (Move Loxodo package and add an icon #8168)
  • Fixed issue where apps:init throws an error upon app creation.
  • Reenabled prompts for unused service deletion in deploy --only.
  • Update Firebase Data Connect local toolkit to v1.8.3, which includes the following changes: (dvd-slideshow: Add package. #8263)
    • Adds a _metadata.distance field to vector similarity search results
    • Fixes auth and request.auth when the request is unauthenticated
    • Fixes an issue with hanging commas in import statements in the generated Web SDK
    • Fixes an issue where the additional union type { __angular?: true } breaks type inference in the generated Web SDK

Supecedes #382118

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sarahec
Copy link
Contributor Author

sarahec commented Mar 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386207


aarch64-darwin

✅ 1 package built:
  • firebase-tools

@sarahec sarahec force-pushed the firebase-tools-13-32-0 branch from 68fbe42 to 55221af Compare March 1, 2025 22:04
@sarahec sarahec force-pushed the firebase-tools-13-32-0 branch from 55221af to 4633580 Compare March 1, 2025 22:07
@momeemt
Copy link
Member

momeemt commented Mar 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386207


aarch64-darwin

✅ 1 package built:
  • firebase-tools

Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@momeemt momeemt added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 2, 2025
@pbsds pbsds merged commit ef5af1e into NixOS:master Mar 4, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants