fix: support default and reqHandler exports in Angular
#8145
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
exports-angular
branch
from
3788912 to
e4cfcf2
Compare
alan-agius4
changed the title
default and reqHandler exports in Angulardefault and reqHandler exports in Angular
Updated the export structure to ensure both `default` and `reqHandler` exports function when using Angular.
alan-agius4
force-pushed
the
exports-angular
branch
from
e4cfcf2 to
6bfdff0
Compare
alan-agius4
commented
Jan 28, 2025
jamesdaniels
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
PTAL @leoortizz. This should get us up and running with the Angular 19's default server.ts
9kubczas4
approved these changes
Jan 29, 2025
leoortizz
reviewed
Feb 6, 2025
| @@ -36,7 +36,7 @@ export const docsUrl = "https://firebase.google.com/docs/hosting/frameworks/angu | |||
|
|
|||
| const DEFAULT_BUILD_SCRIPT = ["ng build"]; | |||
|
|
|||
| export const supportedRange = "16 - 18"; | |||
| export const supportedRange = "16 - 19"; | |||
|
thanks @alan-agius4! I added changelog and increased the supported Angular version to 19. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8145 +/- ##
==========================================
+ Coverage 51.12% 51.13% +0.01%
==========================================
Files 423 423
Lines 29722 29711 -11
Branches 6083 6082 -1
==========================================
- Hits 15196 15194 -2
+ Misses 13160 13151 -9
Partials 1366 1366 ☔ View full report in Codecov by Sentry. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the export structure to ensure both
defaultandreqHandlerexports function when using Angular.