Transaction processor refactor #5799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmederosalvarado
force-pushed
the
refactor/tx-processor
branch
from
20f703b to
393b55d
Compare
…Eth/nethermind into refactor/tx-processor
…Eth/nethermind into refactor/tx-processor
…Eth/nethermind into refactor/tx-processor
jmederosalvarado
requested review from
asdacap,
MarekM25,
LukaszRozmej and
deffrian
marcindsobczak
approved these changes
Jun 12, 2023
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Outdated
Show resolved
Hide resolved
MarekM25
reviewed
Jun 13, 2023
MarekM25
reviewed
Jun 13, 2023
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Outdated
Show resolved
Hide resolved
MarekM25
reviewed
Jun 13, 2023
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Outdated
Show resolved
Hide resolved
MarekM25
reviewed
Jun 13, 2023
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Outdated
Show resolved
Hide resolved
MarekM25
reviewed
Jun 13, 2023
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Show resolved
Hide resolved
deffrian
approved these changes
Jun 13, 2023
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Outdated
Show resolved
Hide resolved
| if (!noValidation) _worldState.SubtractFromBalance(caller, senderReservedGasPayment, spec); | ||
| if (commit) | ||
| if (validate) | ||
| _worldState.SubtractFromBalance(tx.SenderAddress, senderReservedGasPayment, spec); |
There was a problem hiding this comment.
I think we can move it inside if, as senderReservedGasPayment for system txs is zero
smartprogrammer93
approved these changes
Jun 15, 2023
MarekM25
reviewed
Jun 16, 2023
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Show resolved
Hide resolved
MarekM25
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TransactionProcessor.Executelogic into multiplevirtualmethods to improve on both readability and extensibility.Types of changes
What types of changes does your code introduce?
Testing
Pre-Merge Posdao Tests passed
Post-Merge Posdao Tests passed