Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean RLP APIs #21

Closed
tkstanczak opened this issue Aug 2, 2018 · 0 comments
Closed

Clean RLP APIs #21

tkstanczak opened this issue Aug 2, 2018 · 0 comments
Assignees

Comments

@tkstanczak
Copy link
Member

tkstanczak commented Aug 2, 2018

We would like to have RLP as a relatively independent library (either as a single project or coupled with Nethermind.Core only).

At the moment there are numerous APIs in RLP to allow for greater code optimization in Patricia Tree and other areas. As a result, the APIs can be confusing and not easily reusable in other projects.

Any changes here would need to assure that the existing optimizations are still supported.

In general, we have three approaches now:

  1. original that does quite a lot of allocations
  2. new one with creating buffers and block copy
  3. newer one with spans

They also take different arguments depending on the level of optimizations needed (with Patricia Tree going most hardcore).

It would be great to review, improve and systematize the RLP APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant