Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction processor refactor #5799

Merged
merged 40 commits into from
Jun 19, 2023
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
15d2378
Bump to 1.19.0-rc
kamilchodola May 11, 2023
7bec712
Disable removing tx index on archive (#5693)
asdacap May 15, 2023
d876507
Add Shanghai hard-fork settings for Chiado testnet (#5688)
rubo May 15, 2023
2364a88
Split function into small
deffrian May 15, 2023
75c1fe1
If account exists
deffrian May 15, 2023
9df727d
Fix test
deffrian May 15, 2023
dee7389
AddToBalanceAndCreateIfNotExists
deffrian May 15, 2023
ea05f45
Add required to sync message
deffrian May 16, 2023
f9db2f2
Merge pull request #21 from NethermindEth/refactor-tx-processor
deffrian May 16, 2023
7d71b0d
Extract some execution logic into methods
jmederosalvarado May 16, 2023
f1eafea
start refactor
jmederosalvarado May 23, 2023
c86f23e
continue refactor
jmederosalvarado May 24, 2023
a2e20f0
refactor finished?
jmederosalvarado May 24, 2023
3ab352c
Fix: Swap BuyGas and IncNonce in TransactionProcessor
jmederosalvarado May 24, 2023
cd23f56
Tests are all passing
jmederosalvarado May 24, 2023
b531cd6
Fix test attribute
jmederosalvarado May 24, 2023
8c20811
fix fee paying on system txs
jmederosalvarado May 25, 2023
ee4c184
use [TestCase] on [TestFixture] classes
jmederosalvarado May 25, 2023
eb06a14
Merge branch 'master' into refactor/tx-processor
jmederosalvarado Jun 12, 2023
393b55d
Merge branch 'master' into refactor/tx-processor
jmederosalvarado Jun 12, 2023
93ccfde
Merge branch 'master' into refactor/tx-processor
jmederosalvarado Jun 12, 2023
73d5389
Merge branch 'refactor/tx-processor' of https://github.com/Nethermind…
jmederosalvarado Jun 12, 2023
b19cfd9
Merge branch 'refactor/tx-processor' of https://github.com/Nethermind…
jmederosalvarado Jun 12, 2023
5d6aec1
Merge branch 'refactor/tx-processor' of https://github.com/Nethermind…
jmederosalvarado Jun 12, 2023
33739b6
Merge branch 'master' into refactor/tx-processor
jmederosalvarado Jun 13, 2023
5d00b46
Change method ordering in TxProcessor
jmederosalvarado Jun 13, 2023
1059197
Rename blk to header
jmederosalvarado Jun 14, 2023
4e22d2d
Add warning when tx sender doesn't exist
jmederosalvarado Jun 14, 2023
d3f211f
Merge branch 'master' into refactor/tx-processor
jmederosalvarado Jun 14, 2023
320c605
Merge branch 'master' into refactor/tx-processor
jmederosalvarado Jun 14, 2023
531b72f
Fix merge error
jmederosalvarado Jun 14, 2023
6417e8f
AddToBalanceAndCreateIfNotExists
jmederosalvarado Jun 14, 2023
468da44
Update TransactionProcessor.cs
smartprogrammer93 Jun 15, 2023
cc36ff5
Merge branch 'review/pr-5799' into refactor/tx-processor
smartprogrammer93 Jun 15, 2023
ccd4b68
fix format
smartprogrammer93 Jun 15, 2023
08b0ee8
Merge branch 'master' into refactor/tx-processor
jmederosalvarado Jun 16, 2023
fcd855e
Delete unused QuickFail
jmederosalvarado Jun 16, 2023
c89f343
Add tests
Jun 16, 2023
8f5bca1
Merge branch 'master' into refactor/tx-processor
jmederosalvarado Jun 17, 2023
9c42936
Merge remote-tracking branch 'origin/master' into refactor/tx-processor
jmederosalvarado Jun 19, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add warning when tx sender doesn't exist
  • Loading branch information
jmederosalvarado committed Jun 14, 2023
commit 4e22d2d79e5107745c2848447442749dce4e6ce3
Original file line number Diff line number Diff line change
@@ -279,6 +279,8 @@ private bool RecoverSenderIfNeeded(Transaction tx, IReleaseSpec spec, ExecutionO

if (!_worldState.AccountExists(tx.SenderAddress))
{
_logger.Warn($"TX sender account does not exist {tx.SenderAddress} - trying to recover it");

Address prevSender = tx.SenderAddress;
// hacky fix for the potential recovery issue
if (tx.Signature is not null)