Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Settings Not stored #439

Closed
magdesign opened this issue Dec 12, 2019 · 29 comments
Closed

Project Settings Not stored #439

magdesign opened this issue Dec 12, 2019 · 29 comments
Labels
func:gui status:confirmed type:bug Something isn't working

Comments

@magdesign
Copy link
Contributor

magdesign commented Dec 12, 2019 •
edited by devernay
Loading

Natron 2.3.15 Snapshot (RC11 and RC12)
Ubuntu 18.04 LTS (PopOS)

Everytime I open a project in Natron, the project automatically is set to:

Output Format  1920x1080 pixel
25fps

Even if the project was stored with

Output Format  1920x1200
30fps

It seems that saving a file does not save project settings at all, especially resolution and frame rate.
@rodlie
Copy link
Contributor

rodlie commented Dec 13, 2019

Project settings are saved, example UHD_4K 30:

<item>
		<Name>outputFormat</Name>
		<Type>Choice</Type>
		<Dimension>1</Dimension>
		<Secret>0</Secret>
		<MasterIsAlias>0</MasterIsAlias>
		<item>
			<Enabled>1</Enabled>
			<HasAnimation>0</HasAnimation>
			<Value>7</Value>
			<Default>6</Default>
			<HasMaster>0</HasMaster>
			<Expression></Expression>
			<ExprHasRet>0</ExprHasRet>
		</item>
		<ChoiceLabel>UHD_4K</ChoiceLabel>
		<UserKnob>0</UserKnob>
	</item>
	<item>
		<Name>frameRate</Name>
		<Type>Double</Type>
		<Dimension>1</Dimension>
		<Secret>0</Secret>
		<MasterIsAlias>0</MasterIsAlias>
		<item>
			<Enabled>1</Enabled>
			<HasAnimation>0</HasAnimation>
			<Value>3.00000000000000000e+01</Value>
			<Default>2.40000000000000000e+01</Default>
			<HasMaster>0</HasMaster>
			<Expression></Expression>
			<ExprHasRet>0</ExprHasRet>
		</item>
		<UserKnob>0</UserKnob>
	</item>

Project settings are restored, but the combo box is not set correctly.

project-restore

rodlie added a commit to rodlie/Natron that referenced this issue Dec 13, 2019
@rodlie
Engine/Project: update default format after load
0c629cc 
Issue NatronGitHub#439
@rodlie rodlie mentioned this issue Dec 13, 2019
Closed
@magdesign
Copy link
Contributor Author

It does not really save them, you recognize it when there is a ramp and/or a reformat node in then scene.
I am working on 1920x1200, everytime I open the scene, the ramp and all reformats are on 1920x1080 as well as the scene settings, which results in renders with black borders.

@rodlie
Copy link
Contributor

rodlie commented Dec 30, 2019

Are the ramp/reformat ok after you change the default format in the project settings to 1920x1200?

@magdesign
Copy link
Contributor Author

Yes, they are.

@rodlie
Copy link
Contributor

rodlie commented Dec 30, 2019

Then my patch should work, I will double check a bit later today (I'm not in front of my main dev machine at the moment).

@splidje
Copy link
Contributor

splidje commented Dec 30, 2019

Hello. I have a branch here called #439, which I believe is a fix:
https://github.com/splidje/Natron

@magdesign
Copy link
Contributor Author

magdesign commented Dec 30, 2019 •
edited
Loading

Is it possible to get a linux binary of your fork?
Tried compiling but getting errors:

sh: 1: Syntax error: word unexpected (expecting ")")
sh: 1: Syntax error: word unexpected (expecting ")")
sh: 1: Syntax error: word unexpected (expecting ")")
Project ERROR: pyside development package not found

@devernay
Copy link
Member

devernay commented Jan 4, 2020

@rodlie do you have a patch for this issue? Should we consider this high-priority?

@rodlie
Copy link
Contributor

rodlie commented Jan 4, 2020

Yes, but it seems the issue was not resolved for @magdesign. I'm currently not able to replicate the issue he has, so please (@magdesign) send me a simplified project where I can replicate your issue.

@devernay devernay added this to the 2.3 milestone Jan 4, 2020
@magdesign
Copy link
Contributor Author

Here the link: https://cloud.magdesign.ch/index.php/s/ztRntC6wxZsmtZj
Project is saved as 1920x1200
Frame range: 1 last 1500
Frame Rate: 30

@rodlie
Copy link
Contributor

rodlie commented Jan 4, 2020

Thanks, will review issue later tonight when I get home.

@magdesign
Copy link
Contributor Author

Edit: The thing with the Reformat I just realized that in the other projects I did not select "Distort" in the dropdown, but framerate and scene range issue as well as scene settings remain on HD persist. Thanks for looking in to it, very appreciated!

@devernay devernay mentioned this issue Jan 5, 2020
Closed
@rodlie
Copy link
Contributor

rodlie commented Jan 6, 2020

The patch from @splidje (splidje@2cabb20) works here.

@devernay
Copy link
Member

devernay commented Jan 6, 2020

Great! Let us pull it then.
@splidje please tell us if you want to appear in the list of contributors, and under which name.

splidje added a commit to splidje/Natron that referenced this issue Jan 7, 2020
@splidje
NatronGitHub#439 rearranged order in choiceRestoration to ensure _cur…
2cabb20 
…rentEntry is set before clone, and thus the resulting updateGUI
splidje added a commit to splidje/Natron that referenced this issue Jan 7, 2020
@splidje
Merge branch 'RB-2.3' into NatronGitHub#439
fbd841b
@splidje
Copy link
Contributor

splidje commented Jan 7, 2020

@devernay, yes please. Could you put "Jonathan Hearn"

@coveralls coveralls mentioned this issue Jan 7, 2020
Merged
rodlie added a commit that referenced this issue Jan 7, 2020
@rodlie
Merge pull request #446 from splidje/#439
887d553 
#439
@rodlie
Copy link
Contributor

rodlie commented Jan 7, 2020

Issue is now considered fixed, close.

@rodlie rodlie closed this as completed Jan 7, 2020
@devernay
Copy link
Member

devernay commented Jan 8, 2020

Thank you @splidje added you in e8d25fb

@magdesign
Copy link
Contributor Author

magdesign commented Jan 8, 2020 •
edited
Loading

Just built the newest version e8d25fb (Git branch RB-2.3) and tested.
The issue persists, is the fix from splidje in another branch?

See video demonstration of the issue here: https://vimeo.com/383488301
password: natron

Creating a comp witt settings: 1920x1200, 1500frames long, 30fps
saving the comp, close Natron, open saved comp again, scene settings lost.

Ubuntu 18.04LTS, PopOS

@rodlie
Copy link
Contributor

rodlie commented Jan 8, 2020

Well, that's odd. It works fine here with the patch applied.
simplescreenrecorder-2020-01-08_16.58.14.mkv.zip

@magdesign
Copy link
Contributor Author

magdesign commented Jan 8, 2020 •
edited
Loading

Edit:

YES! it works, thanks for the fix!
I had to oremove all hidden Natron files:
.config/INRIA/
.Natron/

@devernay devernay mentioned this issue Jan 11, 2020
Closed
@devernay
Copy link
Member

@magdesign @rodlie be careful, I suspect the fix caused a regression: #447

@devernay
Copy link
Member

@splidje do you have an idea why it may have broken some projects? (see #447)

@devernay
Copy link
Member

confirmed: this fix caused #447
I propose to revert this fix, and close #447
We have to find a solution that does not break loading existing projects.

The following unit tests are broken by this fix:

TestFrameBlend : FAIL
TestMultiPlaneEXR : FAIL
TestMultiPlaneORA : FAIL
TestMultiPlanePSD : FAIL
TestMultiPlaneXCF : FAIL
TestRetimeTransform : FAIL
TestTimeBlur : FAIL
TestZMask : FAIL

devernay added a commit that referenced this issue Jan 11, 2020
@devernay
Revert "#439 rearranged order in choiceRestoration to ensure _current…
838ebf1 
…Entry is set before clone, and thus the resulting updateGUI"

This reverts commit 2cabb20.
@devernay
Copy link
Member

devernay commented Jan 11, 2020 •
edited
Loading

838ebf1 reverted change from 2cabb20

@devernay devernay reopened this Jan 11, 2020
@devernay
Copy link
Member

please run unit tests before committing a new fix, and thanks to everyone who can help on this.
If you don't know how to run unit tests, simply load the project mentionned in #447 and check if the output channels look ok in the nodegraph

@rodlie
Copy link
Contributor

rodlie commented Jan 11, 2020

I'm sorry for not running the unit tests, will do so in the future. I have time tomorrow to help look more into this issue.

@devernay
Copy link
Member

that's ok @rodlie ! we're lucky that I took a look at the test results. I'll also more consistently post the test results with the binaries, since they can be very helpful.

splidje added a commit to splidje/Natron that referenced this issue Jan 12, 2020
@splidje
NatronGitHub#439 Forced hasChanged to true in call to setValue in cho…
a509a9d 
…iceRestoration to ensure outputFormat choice GUI updated on load.
splidje pushed a commit to splidje/Natron that referenced this issue Jan 13, 2020
Merge branch 'RB-2.3' of https://github.com/NatronGitHub/Natron into N…
36c1d6b 
…atronGitHub#439

Conflicts:
	Engine/KnobTypes.cpp
@coveralls coveralls mentioned this issue Jan 13, 2020
Merged
devernay added a commit that referenced this issue Jan 19, 2020
@devernay
Merge pull request #450 from splidje/#439
659ae57 
#439 Forced hasChanged to true in call to setValue in choiceRestorati…
@devernay
Copy link
Member

This should be fixed by #450, @rodlie @splidje @magdesign can you please test that the latest RC (RC15) fixes this?

@magdesign
Copy link
Contributor Author

Scene settings are loading correct with RC15 (on Ubuntu 18.04 Linux)
Thank you!

frameblend.ntp renders without errors,
but do not exactly know how to check what was wrong with the frameblending node,
looks like this: https://user-images.githubusercontent.com/3778071/72196802-9d635100-33cf-11ea-8e14-ccd992127aca.png

rodlie added a commit to rodlie/Natron that referenced this issue May 19, 2020
@rodlie
Gui: fix LineEdit dropEvent path on Windows
de22c02 
Ref: NatronGitHub#439
@rodlie rodlie mentioned this issue May 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
func:gui status:confirmed type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@devernay @magdesign @splidje @rodlie