#439 rearranged order in choiceRestoration to ensure _currentEntry is…

… set before clone, and thus the resulting updateGUI
NatronGitHub · Dec 30, 2019 · 2cabb20 · 2cabb20
1 parent dd13ca8
commit 2cabb20
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/Engine/KnobTypes.cpp b/Engine/KnobTypes.cpp
@@ -1140,16 +1140,7 @@ KnobChoice::choiceRestoration(KnobChoice* knob,
 {
     assert(knob);
 
-    ///Clone first and then handle restoration of the static value
-    clone(knob);
-    setSecret( knob->getIsSecret() );
-    if ( getDimension() == knob->getDimension() ) {
-        for (int i = 0; i < knob->getDimension(); ++i) {
-            setEnabled( i, knob->isEnabled(i) );
-        }
-    }
-
-
+    // ensure _currentEntry is set before eventually triggering GUI update
     {
         QMutexLocker k(&_entriesMutex);
         if (id >= 0) {
@@ -1160,6 +1151,15 @@ KnobChoice::choiceRestoration(KnobChoice* knob,
         }
     }
 
+    ///Clone first and then handle restoration of the static value
+    clone(knob);
+    setSecret( knob->getIsSecret() );
+    if ( getDimension() == knob->getDimension() ) {
+        for (int i = 0; i < knob->getDimension(); ++i) {
+            setEnabled( i, knob->isEnabled(i) );
+        }
+    }
+
     if (id >= 0) {
         setValue(id);
     }