Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gui: fix LineEdit dropEvent path on Windows #497

Closed
wants to merge 1 commit into from
Closed

Gui: fix LineEdit dropEvent path on Windows #497

wants to merge 1 commit into from

Conversation

rodlie
Copy link
Contributor

@rodlie rodlie commented May 19, 2020 •
edited
Loading

This removes the leading slash in LineEdit dropEvent path on Windows.

#493

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling de22c02 on rodlie:issue439 into ec0c2ec on NatronGitHub:RB-2.3.

@devernay devernay mentioned this pull request May 25, 2020
Closed
@devernay devernay self-requested a review May 25, 2020 23:30
devernay
devernay requested changes May 25, 2020
View reviewed changes
Copy link
Member

@devernay devernay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like using toLocalFile() instead of path() is a better fix, see my comments in #493

@rodlie
Copy link
Contributor Author

rodlie commented May 26, 2020

It probably is, close for now.

@rodlie rodlie closed this May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devernay devernay devernay requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodlie @coveralls @devernay