Fixes for ZoneHVAC:HybridUnitaryHVAC

[matthew-larson]

Pull request overview

• Fixes ZoneHVAC:HybridUnitaryHVAC Availability Manager List Name #7505, ZoneHVAC:HybridUnitaryHVAC Requested Outdoor Air Flow Rate #7506, ZoneHVAC:HybridUnitaryHVAC Second and Third fuel types - consumption is not metered #7520, ZoneHVAC:HybridUnitaryHVAC unit shuts off when there is no load but ventilation is requested #7748, ZoneHVAC:HybridUnitaryHVAC load not being accounted for in additional HVAC equipment #7749, ZoneHVAC:HybridUnitaryHVAC - Change lookup tables to use Watts instead of kW #7750, ZoneHVAC:HybridUnitaryHVAC - Missing output variables for return air and relief air values #7751, ZoneHVAC:HybridUnitaryHVAC - Output variable for outdoor air node is reporting no flow rate during 100% OA operation #7752, ZoneHVAC:HybridUnitaryHVAC is not included in any reporting summary tables for output #7753, ZoneHVAC:HybridUnitaryHVAC is not metering its water use #7754, ZoneHVAC:HybridUnitaryHVAC - Unit is providing max ventilation instead of minimum ventilation in ventilation mode #7800
• This pull request fixes various issues regarding the ZoneHVAC:HybridUnitaryHVAC object including correct load and ventilation calculations, handling of minimum ventilation requirements, use of availability managers, and correct outputs for variables, meters, and summary tables. It also changes the lookup tables for System Electric Power, Supply Fan Electric Power, Second Fuel Consumption, and Third Fuel Consumption to expect values to be in Watts instead of kW. The associated test file UnitaryHybridUnitTest_DOSA.idf and example file UnitaryHybridAC_DedicatedOutsideAir.idf was also updated to reflect lookup tables in Watts instead of kW.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

I'm not going to slog through every defect this fixes. It looks like this is going to make some great improvements in the hybrid unitary system, and CI is very happy, only showing diffs in the one expected file.

[Myoldmopar]

The number of lookup table fields here is quite ridiculous. But adding these notes are a good addition that doesn't affect functionality at all, and can only help people get the right inputs in there.

[Myoldmopar]

👍