Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZoneHVAC:HybridUnitaryHVAC Second and Third fuel types - consumption is not metered #7520

Closed
3 tasks
mjwitte opened this issue Sep 22, 2019 · 0 comments · Fixed by #7827
Closed
3 tasks

ZoneHVAC:HybridUnitaryHVAC Second and Third fuel types - consumption is not metered #7520

mjwitte opened this issue Sep 22, 2019 · 0 comments · Fixed by #7827
Assignees
Labels
Defect Includes code to repair a defect in EnergyPlus NotIDDChange Code does not impact IDD (can be merged after IO freeze)

Comments

@mjwitte
Copy link
Contributor

mjwitte commented Sep 22, 2019

Issue overview

Based on code review while removing fuel type synonyms, it appears that:

  1. These energy consumption variables for ZoneHVAC:HybridUnitaryHVAC are not connected to a meter:
    Zone Hybrid Unitary HVAC Secondary Fuel Consumption
    Zone Hybrid Unitary HVAC Third Fuel Consumption Rate

  2. Zone Hybrid Unitary HVAC Supply Fan Electric Energy is metered, that seems ok. But Zone Hybrid Unitary HVAC Electric Energy is also metered. If the fan energy is included in this, then it's gettting double-counted on the electric meter.

  3. Field: First Fuel Type has a full range of choices, but the default it electricity (in code, noted in the IDD), but this appears to be connected to the Electric meter - not variable based on which fuel type is specified in the input. Actually, I'm not finding where this is metered.

  4. There are several (maybe more) variables which have SetupOutputVariable statements but searching HybridUnitaryAirConditioners.cc for the variable name shows it does not appear to be used. Stopped looking after these three, there could be more?

            SetupOutputVariable("Zone Hybrid Unitary HVAC Electric Energy",
                                OutputProcessor::Unit::J,
                                ZoneHybridUnitaryAirConditioner(UnitLoop).FinalElectricalEnergy,

            SetupOutputVariable("Zone Hybrid Unitary HVAC Requested Outdoor Air Ventilation Mass Flow Rate",
                                OutputProcessor::Unit::kg_s,
                                ZoneHybridUnitaryAirConditioner(UnitLoop).MinOA_Msa,
            SetupOutputVariable("Zone Hybrid Unitary HVAC Ventilation Air Mass Flow Rate",
                                OutputProcessor::Unit::kg_s,
                                ZoneHybridUnitaryAirConditioner(UnitLoop).SupplyVentilationAir,

Details

Some additional details for this issue (if relevant):

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here) - don't have any defect files - will need some for this
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@nealkruis nealkruis self-assigned this Jan 20, 2020
@nealkruis nealkruis added Defect Includes code to repair a defect in EnergyPlus NotIDDChange Code does not impact IDD (can be merged after IO freeze) labels Mar 4, 2020
@nealkruis nealkruis added this to the EnergyPlus 9.3.0 milestone Mar 4, 2020
@nealkruis nealkruis linked a pull request Mar 4, 2020 that will close this issue
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus NotIDDChange Code does not impact IDD (can be merged after IO freeze)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants