Corrected MultiSpeed DX Cooling Coil sizing variable names and capacity reporting issues #7495

Nigusse · 2019-09-10T17:03:56Z

Pull request overview

Fixes #7477. This fixes inconsistent reporting in multi-speed DX cooling and heating coils:

corrected inconsistent gross rated total capacity, SHR and rated flow rates names for different speeds
now the reporting includes for all speed level for multi-speed DX cooling coils
diffs are expected/justified based on this change in tabular reporting.
resolved design size values difference when DX coils are fully and partially autosized
SHR values now sized using the autosided capacities when design size values are available

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
- Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
- Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus

Review Checklist

This will not be exhaustively relevant to every PR.

Functional code review (it has to work!)
If defect, results of running current develop vs this branch should exhibit the fix
CI status: all green or justified
Performance: CI Linux results include performance check
Unit Test(s)
C++ checks:
- Argument types
- If any virtual classes, ensure virtual destructor included, other things
If output changes, including tabular output structure, add to output rules file for interfaces

into 167576747_Issue7381

Nigusse · 2019-09-13T15:33:59Z

This is ready for review.

Nigusse · 2019-09-13T15:35:16Z

@Myoldmopar @rraustad Note that I have merged in issue #7381 to this branch.

Myoldmopar · 2019-09-13T19:48:25Z

Putting this as milestone 9.2 for now since it doesn't appear at first glance to change I/O in a structural manner, but I need to look at the details before making a final decision on that. We'll be freezing the code next week so it may be too late anyway, but if it is clean it would be nice to drop it in.

Myoldmopar · 2019-09-20T02:04:15Z

Unlikely to get this reviewed before we make final cutoff tomorrow afternoon. I'm going to shift the milestone back to future.

Nigusse · 2019-09-24T13:48:13Z

SQL output for develop: the rated sizing parameters (Capacity, flow rates, ...) are not reported for all speeds. Note also that the user specified variable naming is not consistent.

Nigusse · 2019-09-24T13:52:10Z

SQL output for this branch: the rated sizing parameters (Capacity, flow rates, ...) are reported for all speeds of cooling and heating coils. Note also that the user specified sizing variables naming is now consistent.

Myoldmopar · 2019-09-28T11:15:28Z

@Nigusse I believe this branch is good to go, but with the merge of #7436, there are conflicts. If you can resolve them I'll get this merged in.

Nigusse · 2019-09-30T12:42:59Z

@Myoldmopar working on it now.

Nigusse · 2019-09-30T13:09:11Z

@Myoldmopar Merged in develop and run the unit test suite. All happy.

Nigusse · 2019-09-30T16:13:09Z

The multi-speed DX cooling coil capacity sizing related report variable names were modified for consistency. Also the design rated capacity at lower speeds are now corrected, the lower speed design cooling capacity are fraction of the design capacity at maximum speed, instead of the user specified maximum speed capacity.

…Issue7477

mjwitte

Tested this vs develop and saw the expected changes using multispeed.idf as-is (moved to v9.2).
The name re-ordering in the sizing labels warrants an entry in \src\Transition\OutputRulesFiles\OutputChanges9-2-0-to-9-3-0.md
Added sizing objects to the defect file and expected to see a reported "Design Size . . . " for every "User-Specified . . .". This was true for all except "Speed 2 Gross Rated Heating Capacity", the design size output is missing for this one. See After-multispeed-AddSizing.eio
Also made a fully autosized version of the defect file and compared to the hard-sized file with sizing. I was surprised that the Coil:Cooling:DX:MultiSpeed, ASHP CLG COIL, Design Size Speed 2 Gross Rated Total Cooling Capacity was not the same in both files. So maybe that's because the capacity design size is being calculated based on the hard airflow rate? So, I made the airflow rate and the shr autosize in both files and the design gross cooling capacity is still different between the two. Is it broken, or am I missing something? Compare the eio output for After-multispeed-AddSizing-AllAutosize vs After-multispeed-AddSizing-AutoSizeSHRAndAirFlow.

Test files attached: 7477-MulitSpeedDX.zip

Nigusse · 2019-10-11T20:52:43Z

"Added sizing objects to the defect file and expected to see a reported "Design Size . . . " for every "User-Specified . . .". This was true for all except "Speed 2 Gross Rated Heating Capacity", the design size output is missing for this one. See After-multispeed-AddSizing.eio"

@mjwitte I moved the cooling capacity sizing calc to Requestsizing() function. I think, this function does not report the design capacity (may be any design variable) unless the user specified value is different from the design value by more than 10%. This is a quick reply to item 3.

mjwitte · 2019-10-14T15:00:26Z

@Nigusse I may be wrong, but my understanding is that both values should always be reported, but the >10% difference triggers a warning (with DisplayExtraWarnings?).

rraustad · 2019-10-14T15:06:47Z

If not autosized, and difference is greater than 0.1, both are reported, otherwise only user specified is reported.

            if (PrintWarningFlag) {
                if (IsAutoSize && SizingResult > 0.0) {
                    ReportSizingOutput(CompType, CompName, "Design Size " + SizingString, SizingResult);
                } else if (SizingResult > 0.0) {
                    AutosizeUser = SizingResult;
                    if ((std::abs(AutosizeDes - AutosizeUser) / AutosizeUser) > AutoVsHardSizingThreshold) {
                        ReportSizingOutput(
                            CompType, CompName, "Design Size " + SizingString, AutosizeDes, "User-Specified " + SizingString, AutosizeUser);
                    } else {
                        ReportSizingOutput(CompType, CompName, "User-Specified " + SizingString, AutosizeUser);
                    }

mjwitte · 2019-10-16T17:56:50Z

@rraustad @Nigusse I didn't realize the reporting was suppressed for <10% difference. So, OK, if I change that to exceed 10% then I see design reported for every user value. So, that part's ok.

Any thoughts on the other question about fully autosized capacity being different from the design values reported when user-specified?

Nigusse · 2019-11-01T15:08:22Z

@mjwitte addressed item 2. This branch was meant to include a final fix for issues #7381 and #7477. Now looking at item 4.

Nigusse · 2019-11-01T19:38:51Z

@mjwitte @rraustad The main reason why these two defect files show design size cooling capacity difference is due to differences in sizing method. When it is fully auto-sized, the capacity determined using the RequestSizing() function from the parent object (UnitarySystem) and is set for the DX coil. When there is hard sizing value specified for the DX coil capacity, the design capacity is determined using the autosizing calculation in the DXCoil object. These two sizing methods are slightly different. The RequestSizing() function accounts for fan heat effect in the sizing calculation, while the other is not. I think the way forward in resolving this problem is to use the RequestSizing() in both places. I think, this defect must have been there longer.

Nigusse · 2019-11-08T16:41:54Z

@mjwitte As you have pointed out partial autosizing of multi-speed DX coils fields has been broken. I have found partial autosizing problem for Rated Total Cooling/Heating Capacity, Rated Air Flow Rates, Rated Sensible Heat Ratio, Evaporative Condenser Air Flow Rate, etc. All capacity and flow rate related sizing variables were broken or did not work in the first place when there is partial autosizing. Fixing these issues has broken else where, so reverted some of the changes I made. The remaining issues will be addressed after reviewing the this push, perhaps this issue should be divided into multiple bug issues.

Nigusse · 2019-11-12T16:03:56Z

Fully autosized Multispeed DX coils results:

Nigusse · 2019-11-12T16:04:52Z

Partially autosized Multispeed DX coils results:

Nigusse · 2019-11-12T16:08:56Z

This fix resolves the mismatch between design size values when fully and partially autosized.

into 168195503_Issue7477

…Issue7477

mjwitte

@Nigusse Thanks for addressing all of the comments. Output looks exactly as expected now. Merging in develop for one more CI round, then this can drop in.

nigusse added 5 commits August 26, 2019 09:47

Merge branch 'develop' into 167576747_Issue7381

4f05d9f

Merge branch '167576747_Issue7381' of https://github.com/NREL/EnergyPlus

a10b8ce

into 167576747_Issue7381

Merge branch '167576747_Issue7381' into 168195503_Issue7477

9b2ffa4

corrected speed level variable name orders

dbcb2a7

added reporting total capacity and SHR value reporting for each speed

4aebc68

Nigusse added the Defect Includes code to repair a defect in EnergyPlus label Sep 10, 2019

nigusse added 5 commits September 11, 2019 09:49

reverted SHR calculation change

dcd1674

corrected flow rate sizing reporting for multispeed DX coils

aafa01f

modified flow and capacity reporting for low speeds

db3702b

Added unit test

2a264bf

Merge branch 'develop' into 168195503_Issue7477

3bfdddb

Myoldmopar added this to the EnergyPlus 9.2.0 milestone Sep 13, 2019

Myoldmopar self-assigned this Sep 18, 2019

Myoldmopar modified the milestones: EnergyPlus 9.2.0, EnergyPlus Future Sep 20, 2019

Merge branch 'develop' into 168195503_Issue7477

46c00a8

Merge branch 'develop' into 168195503_Issue7477

359a6ed

mjwitte assigned mjwitte and unassigned Myoldmopar Oct 10, 2019

mjwitte self-requested a review October 10, 2019 15:55

Merge remote-tracking branch 'remotes/origin/develop' into 168195503_…

3336bc7

…Issue7477

Nigusse mentioned this pull request Oct 11, 2019

MultiSpeed DX Cooling Coil sizing variable names and capacity reporting issues #7477

Closed

3 tasks

mjwitte requested changes Oct 11, 2019

View reviewed changes

nigusse added 2 commits November 1, 2019 10:48

Merge branch 'develop' into 168195503_Issue7477

e2c46f5

Reorder sizing labels and modified variable names

9429588

Resolving Partial autosize issues for Multi Speed DX Coils (Part 1)

a490dbd

nigusse added 2 commits November 12, 2019 08:23

removed unused variables in DX Coils Sizing

03e0d81

Resolved partial autosize of MultiSpeed DX Coil

5d5ca8a

mjwitte added 2 commits November 13, 2019 09:39

Merge branch '168195503_Issue7477' of https://github.com/NREL/EnergyPlus

637462a

into 168195503_Issue7477

Merge remote-tracking branch 'remotes/origin/develop' into 168195503_…

052c135

…Issue7477

mjwitte approved these changes Nov 13, 2019

View reviewed changes

mjwitte merged commit b4404bb into develop Nov 14, 2019

mjwitte deleted the 168195503_Issue7477 branch November 14, 2019 13:05

mjwitte added the OutputChange Code changes output in such a way that it cannot be merged after IO freeze label Nov 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Corrected MultiSpeed DX Cooling Coil sizing variable names and capacity reporting issues #7495

Corrected MultiSpeed DX Cooling Coil sizing variable names and capacity reporting issues #7495

Nigusse commented Sep 10, 2019 •

edited by mjwitte

Loading

Nigusse commented Sep 13, 2019

Nigusse commented Sep 13, 2019

Myoldmopar commented Sep 13, 2019

Myoldmopar commented Sep 20, 2019

Nigusse commented Sep 24, 2019

Nigusse commented Sep 24, 2019

Myoldmopar commented Sep 28, 2019

Nigusse commented Sep 30, 2019

Nigusse commented Sep 30, 2019

Nigusse commented Sep 30, 2019

mjwitte left a comment

Nigusse commented Oct 11, 2019

mjwitte commented Oct 14, 2019

rraustad commented Oct 14, 2019

mjwitte commented Oct 16, 2019

Nigusse commented Nov 1, 2019

Nigusse commented Nov 1, 2019 •

edited

Loading

Nigusse commented Nov 8, 2019

Nigusse commented Nov 12, 2019

Nigusse commented Nov 12, 2019

Nigusse commented Nov 12, 2019

mjwitte left a comment

Corrected MultiSpeed DX Cooling Coil sizing variable names and capacity reporting issues #7495

Corrected MultiSpeed DX Cooling Coil sizing variable names and capacity reporting issues #7495

Conversation

Nigusse commented Sep 10, 2019 • edited by mjwitte Loading

Pull request overview

Work Checklist

Review Checklist

Nigusse commented Sep 13, 2019

Nigusse commented Sep 13, 2019

Myoldmopar commented Sep 13, 2019

Myoldmopar commented Sep 20, 2019

Nigusse commented Sep 24, 2019

Nigusse commented Sep 24, 2019

Myoldmopar commented Sep 28, 2019

Nigusse commented Sep 30, 2019

Nigusse commented Sep 30, 2019

Nigusse commented Sep 30, 2019

mjwitte left a comment

Choose a reason for hiding this comment

Nigusse commented Oct 11, 2019

mjwitte commented Oct 14, 2019

rraustad commented Oct 14, 2019

mjwitte commented Oct 16, 2019

Nigusse commented Nov 1, 2019

Nigusse commented Nov 1, 2019 • edited Loading

Nigusse commented Nov 8, 2019

Nigusse commented Nov 12, 2019

Nigusse commented Nov 12, 2019

Nigusse commented Nov 12, 2019

mjwitte left a comment

Choose a reason for hiding this comment

Nigusse commented Sep 10, 2019 •

edited by mjwitte

Loading

Nigusse commented Nov 1, 2019 •

edited

Loading