Skip to content

Commit

Permalink
Resolved partial autosize of MultiSpeed DX Coil
Browse files Browse the repository at this point in the history
  • Loading branch information
nigusse committed Nov 12, 2019
1 parent 03e0d81 commit 5d5ca8a
Show file tree
Hide file tree
Showing 3 changed files with 269 additions and 4 deletions.
11 changes: 7 additions & 4 deletions src/EnergyPlus/DXCoils.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3964,6 +3964,7 @@ namespace DXCoils {
DXCoil(DXCoilNum).MSErrIndex.allocate(DXCoil(DXCoilNum).NumOfSpeeds);
DXCoil(DXCoilNum).MSErrIndex = 0;
DXCoil(DXCoilNum).MSRatedTotCap.allocate(DXCoil(DXCoilNum).NumOfSpeeds);
DXCoil(DXCoilNum).MSRatedTotCapDes.allocate(DXCoil(DXCoilNum).NumOfSpeeds);
DXCoil(DXCoilNum).MSRatedSHR.allocate(DXCoil(DXCoilNum).NumOfSpeeds);
DXCoil(DXCoilNum).MSRatedCOP.allocate(DXCoil(DXCoilNum).NumOfSpeeds);
DXCoil(DXCoilNum).MSRatedAirVolFlowRate.allocate(DXCoil(DXCoilNum).NumOfSpeeds);
Expand Down Expand Up @@ -7394,13 +7395,15 @@ namespace DXCoils {
DataConstantUsedForSizing = TempSize;
DataFractionUsedForSizing = 1.0;
MSRatedTotCapDesAtMaxSpeed = TempSize;
DXCoil( DXCoilNum ).MSRatedTotCapDes( Mode ) = TempSize;
PrintFlag = true;
}
TempSize = DXCoil( DXCoilNum ).MSRatedTotCap( Mode );
RequestSizing( CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName );
DXCoil( DXCoilNum ).MSRatedTotCap( Mode ) = TempSize;
if (IsAutoSize) {
MSRatedTotCapDesAtMaxSpeed = TempSize;
DXCoil( DXCoilNum ).MSRatedTotCapDes( Mode ) = TempSize;
}
} else {
// cooling capacity at lower speeds
Expand All @@ -7417,6 +7420,7 @@ namespace DXCoils {
DataConstantUsedForSizing = DXCoil( DXCoilNum ).MSRatedTotCap( DXCoil( DXCoilNum ).NumOfSpeeds );
}
DataFractionUsedForSizing = (float)Mode / DXCoil(DXCoilNum).NumOfSpeeds;
DXCoil( DXCoilNum ).MSRatedTotCapDes( Mode ) = DataConstantUsedForSizing * DataFractionUsedForSizing;
}
TempSize = DXCoil(DXCoilNum).MSRatedTotCap(Mode);
DataEMSOverrideON = DXCoil(DXCoilNum).RatedTotCapEMSOverrideOn(Mode);
Expand Down Expand Up @@ -7789,18 +7793,18 @@ namespace DXCoils {
DataFractionUsedForSizing = 1.0;
if (DXCoil(DXCoilNum).CompanionUpstreamDXCoil > 0) {
NumOfSpeedCompanion = DXCoil(DXCoil(DXCoilNum).CompanionUpstreamDXCoil).NumOfSpeeds;
DataConstantUsedForSizing = DXCoil(DXCoil(DXCoilNum).CompanionUpstreamDXCoil).MSRatedTotCap(NumOfSpeedCompanion);
DataConstantUsedForSizing = DXCoil(DXCoil(DXCoilNum).CompanionUpstreamDXCoil).MSRatedTotCapDes(NumOfSpeedCompanion);
} else {
DataConstantUsedForSizing = DXCoil(DXCoilNum).RatedTotCap(1); // sized above
}
TempSize = DXCoil(DXCoilNum).MSRatedTotCap(Mode);
TempSize = DataSizing::AutoSize;
DataEMSOverrideON = DXCoil(DXCoilNum).RatedTotCapEMSOverrideOn(Mode);
DataEMSOverride = DXCoil(DXCoilNum).RatedTotCapEMSOverrideValue(Mode);
RequestSizing( CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName );
MSRatedTotCapDesAtMaxSpeed = TempSize;
SizingMethod = AutoCalculateSizing;
DataConstantUsedForSizing = TempSize;
DataFractionUsedForSizing = 1.0;
MSRatedTotCapDesAtMaxSpeed = TempSize;
}
PrintFlag = true;
TempSize = DXCoil(DXCoilNum).MSRatedTotCap(Mode);
Expand All @@ -7811,7 +7815,6 @@ namespace DXCoils {
if (IsAutoSize) {
MSRatedTotCapDesAtMaxSpeed = TempSize;
}

} else {
PrintFlag = true;
SizingMethod = HeatingCapacitySizing;
Expand Down
1 change: 1 addition & 0 deletions src/EnergyPlus/DXCoils.hh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@ namespace DXCoils {
bool LatentImpact; // Latent degradation applied to Speed Number > 1
Array1D_int MSErrIndex; // index flag for num speeds/recurring messages
Array1D<Real64> MSRatedTotCap; // Rated cooling capacity for MS heat pump [W]
Array1D<Real64> MSRatedTotCapDes; // Autosized Gross total cooling capacity at rated conditions [watts]
Array1D<Real64> MSRatedSHR; // Rated SHR for MS heat pump [dimensionless]
Array1D<Real64> MSRatedCOP; // Rated COP for MS heat pump [dimensionless]
Array1D<Real64> MSRatedAirVolFlowRate; // Air volume flow rate through unit at rated conditions [m3/s]
Expand Down
Loading

7 comments on commit 5d5ca8a

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (11 of 11 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2611 of 2621 tests passed, 0 test warnings)

Messages:\n

  • 10 tests had: EIO diffs.
  • 10 tests had: Table big diffs.
  • 6 tests had: AUD diffs.
  • 1 test had: ESO small diffs.
  • 1 test had: MTR small diffs.

Failures:\n

regression Test Summary

  • Passed: 679
  • Failed: 10

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1241 of 1241 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (674 of 674 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2571 of 2581 tests passed, 0 test warnings)

Messages:\n

  • 10 tests had: EIO diffs.
  • 10 tests had: Table big diffs.
  • 6 tests had: AUD diffs.
  • 1 test had: ESO small diffs.
  • 1 test had: MTR small diffs.

Failures:\n

regression Test Summary

  • Passed: 659
  • Failed: 10

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-MacOS-10.13-clang: OK (2571 of 2581 tests passed, 2 test warnings)

Messages:\n

  • 10 tests had: EIO diffs.
  • 10 tests had: Table big diffs.
  • 2 tests had: BND diffs.
  • 6 tests had: AUD diffs.
  • 1 test had: ESO small diffs.
  • 1 test had: MTR small diffs.

Failures:\n

regression Test Summary

  • Passed: 659
  • Failed: 10

Build Badge Test Badge

Please sign in to comment.