Skip to content

Commit

Permalink
Reorder sizing labels and modified variable names
Browse files Browse the repository at this point in the history
  • Loading branch information
nigusse committed Nov 1, 2019
1 parent e2c46f5 commit 9429588
Showing 1 changed file with 38 additions and 0 deletions.
38 changes: 38 additions & 0 deletions src/Transition/OutputRulesFiles/OutputChanges9-2-0-to-9-3-0.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,41 @@ This will eventually become a more structured file, but currently it isn't clear
A new column "Peak Load Type to Size On" has been added to the `Coil Sizing Details:Coils` report

See [7397](https://github.com/NREL/EnergyPlus/pull/7397)

### Name re-ordering in the sizing labels and modified variable names for MulitSpeed DX Cooling and Heating Coils

The change impacts rated capacity, rated flow rate, rated sensible heat ratio, etc, see sample changes below

```
Before:
'Speed X' Design Size Design Size Rated Total Cooling Capacity
'Speed X' Design Size Gross Rated Heating Capacity
'Speed X' Design Size Rated Air Flow Rate
'Speed X' Design Size Rated Sensible Heat Ratio
'Speed X' Design Size Evaporative Condenser Air Flow Rate
'Speed X' Design Size Rated Evaporative Condenser Pump Power Consumption
'Speed X' User-Specified User-Specified Total Cooling Capacity
'Speed X' User-Specified Gross Rated Heating Capacity
'Speed X' User-Specified Rated Air Flow Rate
'Speed X' User-Specified Rated Sensible Heat Ratio
'Speed X' User-Specified Evaporative Condenser Air Flow Rate
'Speed X' User-Specified Rated Evaporative Condenser Pump Power Consumption
After:
Design Size 'Speed X' Gross Rated Total Cooling Capacity
Design Size 'Speed X' Gross Rated Heating Capacity
Design Size 'Speed X' Rated Air Flow Rate
Design Size 'Speed X' Rated Sensible Heat Ratio
Design Size 'Speed X' Evaporative Condenser Air Flow Rate
Design Size 'Speed X' Rated Evaporative Condenser Pump Power Consumption
User-Specified 'Speed X' Gross Rated Total Cooling Capacity
User-Specified 'Speed X' Gross Rated Heating Capacity
User-Specified 'Speed X' Rated Air Flow Rate
User-Specified 'Speed X' Rated Sensible Heat Ratio
User-Specified 'Speed X' Evaporative Condenser Air Flow Rate
User-Specified 'Speed X' Rated Evaporative Condenser Pump Power Consumption
```

7 comments on commit 9429588

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (11 of 11 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2610 of 2620 tests passed, 0 test warnings)

Messages:\n

  • 10 tests had: EIO diffs.
  • 10 tests had: Table big diffs.
  • 5 tests had: AUD diffs.

Failures:\n

regression Test Summary

  • Passed: 679
  • Failed: 10

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1240 of 1240 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-MacOS-10.13-clang: OK (2569 of 2580 tests passed, 0 test warnings)

Messages:\n

  • 10 tests had: EIO diffs.
  • 10 tests had: Table big diffs.
  • 5 tests had: AUD diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 834
  • Failed: 1

regression Test Summary

  • Passed: 659
  • Failed: 10

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2570 of 2580 tests passed, 0 test warnings)

Messages:\n

  • 10 tests had: EIO diffs.
  • 10 tests had: Table big diffs.
  • 5 tests had: AUD diffs.

Failures:\n

regression Test Summary

  • Passed: 659
  • Failed: 10

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

168195503_Issue7477 (Unknown) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (674 of 674 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.