Implement new coil vs. space peak sizing simulation logic #4635
Conversation
Renamed sensible SysSizing variables: CoolMixTemp => MixTempAtSensCoolPeak
Conflicts: src/EnergyPlus/ReportSizingManager.cc
…I'm committing my work so I can revert a couple of commits and start over.
…o work. I'm committing my work so I can revert a couple of commits and start over." This reverts commit f69c5ad. Added CoolingPeakLoadType to SysSizing
…olFlowPeak to SysSiz array. Added SysSizPeakDDNum array to DataSizing (contains DD indices for all cooling peaks).
… time step for the sensible cooling load, total cooling load, and cooling flow peaks.
…adSeq. Added to ReportSizing: new function GetCoilDesFlowT (not completed yet)
Conflicts: src/EnergyPlus/DataSizing.hh src/EnergyPlus/ReportSizingManager.cc src/EnergyPlus/SizingManager.cc Signed-off-by: Fred Buhl <wfbuhl@gmail.com>
…oad and water flow sizing calcs, and as well to the coil UA calculation in the Init routine.
… end of SizingManager. Commented this out.
Conflicts: idd/Energy+.idd.in src/EnergyPlus/DataSizing.hh src/EnergyPlus/SimAirServingZones.cc
… outlet air humidity ratio to be 90% relative humidity.
2 similar comments
|
@wfbuhl I was going to add this field to the sizing:system objects coming out of ExpandObjects, but I'm not sure what to put. If the default is VAV, is that consistent with what the "old" calcs were doing? So, VAV = no change in results. But ultimately, for, say a unitary system one of the other choices seems better suited, but that could change results? What would you recommend - write VAV for all system types to maintain the same results, leave this field blank (which will result in VAV but not look silly for constant flow systems), or put in the appropriate choices and let results change. Searching the modified idf files, looks like VAV has been used for all system types. |
|
If it is marked as a required-field, will the input processor fill in 'autosize' so that the GetInput routine never see a blank? |
|
If it's within min-fields the it will get filled with the default, but I On 2/20/2015 10:00 AM, Edwin Lee wrote:
|
|
@Myoldmopar And technically, it's not just blank, the field isn't even there, so if the getinput is doing a check on number of N fields, that may be part of the confusion? |
|
@Myoldmopar @wfbuhl Hold on about the get input processing - some confusion here about whether EnergyPlus was rebuilt for this branch. |
|
@Myoldmopar @wfbuhl Never mind on the getinput stuff. The HVACTemplate files are running ok even without any expandobjects changes. We're just getting rid of these warnings: Ultimately, it's good to get the field names in synch anyway. And I see that these changes do impact sizing, even with defaults. So, maybe I should be varying the coil control input for different system types? |
|
OK cool. Well thanks for addressing ExpandObjects and getting rid of those warnings. Does the coil control input variation belong in this PR as well or can it be marked as a future enhancement? ExpandObjects was the last issue I remember seeing on this PR, so after it is addressed I don't think I need anything further code wise (doc changes should go over here). I'll handle a merge back from develop if we are settled on the code for one last CI pass. |
… field name changes
|
@Myoldmopar I'm almost done. Making a second pass to clean up all the other objects that got new field names from the changes for "during Cooling ..." to "Cooling ...". |
…o Load nomenclature, add missing coil:water:heating convection ratio fields, add one more block of sizing:system fields
|
@Myoldmopar That should be all for the expandobjects updates (even got rid of two longstanding IP warnings about missing fields being filled with defaults in HVACTemplate-5ZoneConstantVolumeChillerBoiler and HVACTemplate-5ZoneFanCoil-DOAS). Let the CI times roll. |
|
Welp, beef0e9 should be it. I merged develop. There were some conflicts with idfs that seemed to get worked out. I am currently spot testing and then if something went awry I'll remedy it and push up again (maybe not til morning). |
|
HospitalLowEnergy had a second EIR chiller that got messed up in transition. I remedied that and looked over the diffs again. Things will be good to go when that goes in. CI is already testing it, so it shouldn't be long now... |
69208874 lbnl coil vs space peak
|
A11; \Central Cooling Capacity Control Method Setting this field to "OnOff" will result in no change to the results. Fred On Fri, Feb 20, 2015 at 8:00 AM, Michael J. Witte notifications@github.com
|
|
Are you saying the IDD needs to be changed for |
|
It is up to you. Might be a good idea. Fred On Mon, Feb 23, 2015 at 11:12 AM, Edwin Lee notifications@github.com
|
|
sigh OK. It'll have to be a brand new PR. I'll make an issue out of it. |
|
I got a hard crash in SimAirServingZones.cc, line 4790 while running 5ZoneVAV-ChilledWaterStorage-Mixed.idf. SysTotCoolCap was being used without being initialized. It appears that an init for SysTotCoolCap is needed around line 4722. |
|
Yes; not sure how this got through. Am I running with uninitialized Fred On Tue, Feb 24, 2015 at 7:35 AM, Brent Griffith notifications@github.com
|
Myoldmopar
changed the title
There's a new input field in Sizing:System, and a couple name changes. Existing inputs should run unchanged, however.