Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to change Sizing:System IDD default #4747

Closed
Myoldmopar opened this issue Feb 23, 2015 · 13 comments · Fixed by #4749
Closed

Need to change Sizing:System IDD default #4747

Myoldmopar opened this issue Feb 23, 2015 · 13 comments · Fixed by #4749
Assignees
Labels
PriorityLow This defect or feature has been declared low priority SeverityHigh This defect is high severity, generally indicating a hard crash without a workaround

Comments

@Myoldmopar
Copy link
Member

The IDD choice for the following needs to be changed to default to OnOff, and the Transition tool needs to re-run.

A11; \Central Cooling Capacity Control Method
\note Method used to control the coil's output
\type choice
\key VAV
\key Bypass
\key VT
\key OnOff
\default VAV

@Myoldmopar Myoldmopar added SeverityHigh This defect is high severity, generally indicating a hard crash without a workaround PriorityLow This defect or feature has been declared low priority labels Feb 23, 2015
@Myoldmopar Myoldmopar self-assigned this Feb 23, 2015
@Myoldmopar
Copy link
Member Author

Note this will likely cause minor diffs similar to those that were accepted when #4635 was merged.

@mjwitte
Copy link
Contributor

mjwitte commented Feb 23, 2015

@Myoldmopar But I thought @wfbuhl said it wouldn't change anything. I'm confused. Do we really want to change this? And my whole question was whether HVACTemplate should be writing something other than VAV for all of these (which is what it currently will do, write VAV).

@Myoldmopar
Copy link
Member Author

I took that to mean that if we had used OnOff as the default from the beginning, we wouldn't have actually been seeing all those tiny diffs. And then changing it and re-transitioning would "undo" those diffs. Maybe I misinterpreted.

@wfbuhl?

@wfbuhl
Copy link
Contributor

wfbuhl commented Feb 23, 2015

"OnOff" will reproduce our old calculation: that is, use the peak system
air flow rate to size the cooling coil. "VAV" uses the air flow rate at the
at the central cooling coil peak load to size the coil. Using "OnOff" as
the default will mean that there are no diffs. But I don't see what the
issue is with diffs: it is not as if we are trying to make every upgrade
give the same results as previously. In any case, the correct input for
this field depends on the system type. Since we are not going to go through
all the test files and change the input for this field by hand, it is
probably best to use the backward compatible choice of "OnOff", which could
just as well have been named "ConstantVolume". It is the most conservative
sizing choice.

Fred

On Mon, Feb 23, 2015 at 11:49 AM, Edwin Lee notifications@github.com
wrote:

I took that to mean that if we had used OnOff as the default from the
beginning, we wouldn't have actually been seeing all those tiny diffs. And
then changing it and re-transitioning would "undo" those diffs. Maybe I
misinterpreted.

@wfbuhl https://github.com/wfbuhl?


Reply to this email directly or view it on GitHub
#4747 (comment).

@mjwitte
Copy link
Contributor

mjwitte commented Feb 23, 2015

@wfbuhl So, for a constant volume system, wouldn't these two options produce the same result? And we should think about the naming of OnOff vs ConstantVolume. I don't recall the initial discussions of where the OnOff name came from.

@wfbuhl
Copy link
Contributor

wfbuhl commented Feb 23, 2015

These options are for sizing. You are telling the system sizing calculation
what kind of system you have. Then it uses that info to size the coil.

There are not many constant volume reheat systems around anymore. There are
more cycling system, it seems to me. If you want to change it to CV, that's
fine with me. There would be a few lines of code to change.

Fred

On Mon, Feb 23, 2015 at 12:37 PM, Michael J. Witte <notifications@github.com

wrote:

@wfbuhl https://github.com/wfbuhl So, for a constant volume system,
wouldn't these two options produce the same result? And we should think
about the naming of OnOff vs ConstantVolume. I don't recall the initial
discussions of where the OnOff name came from.


Reply to this email directly or view it on GitHub
#4747 (comment).

@mjwitte
Copy link
Contributor

mjwitte commented Feb 23, 2015

@wfbuhl No, I'm fine with the OnOff terminology, just trying to understand the nuances. Not to be negative, but I don't think the implications of this field will be immediately obvious with either keyword, so it will need explanation. The bigger question is if we want to change the default and change the idfs.

@Myoldmopar
Copy link
Member Author

Myoldmopar commented Feb 23, 2015 via email

@mjwitte
Copy link
Contributor

mjwitte commented Feb 24, 2015

@Myoldmopar Then we need to change HVACTemplate. We can go with the no-impact OnOff everywhere, or stick our necks out and use VAV as appropriate.

@Myoldmopar
Copy link
Member Author

Myoldmopar commented Feb 24, 2015 via email

@mjwitte
Copy link
Contributor

mjwitte commented Feb 24, 2015

@Myoldmopar So, will you make the replacements in expandobjects? It should be very straightforward.

@Myoldmopar
Copy link
Member Author

Myoldmopar commented Feb 24, 2015 via email

@wfbuhl
Copy link
Contributor

wfbuhl commented Feb 24, 2015

Thank you Edwin

On Mon, Feb 23, 2015 at 6:46 PM, Edwin Lee notifications@github.com wrote:

Yes


Reply to this email directly or view it on GitHub
#4747 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PriorityLow This defect or feature has been declared low priority SeverityHigh This defect is high severity, generally indicating a hard crash without a workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants