Implement new data center HVAC simulation model #4624
Conversation
|
@Myoldmopar @lgentile it has been 7 days since this pull request was last updated. |
3 similar comments
|
@Myoldmopar @lgentile it has been 7 days since this pull request was last updated. |
|
@Myoldmopar @lgentile it has been 7 days since this pull request was last updated. |
|
@Myoldmopar @lgentile it has been 7 days since this pull request was last updated. |
|
@Myoldmopar @lgu1234 What is the status on this pull request? |
|
It's on my review checklist and I should be able to make a pass today. |
|
@Myoldmopar @lgentile it has been 7 days since this pull request was last updated. |
2 similar comments
|
@Myoldmopar @lgentile it has been 7 days since this pull request was last updated. |
|
@Myoldmopar @lgentile it has been 7 days since this pull request was last updated. |
|
@kbenne @Myoldmopar @lgentile it has been 7 days since this pull request was last updated. |
|
@kbenne Assigning myself to this since there are transition changes. Feel free to take another one of mine 😉 @Nigusse Do you have the transition rules written out for this PR? It looks like the |
|
@Myoldmopar Yes, transition rules were provided at the time of final code commit. If you cannot find it I will forward it to you. |
|
@Myoldmopar The two test files with fatal error have not been transitioned yet. I don't see test files with node connection errors. Did you transition the rest of the test files? Do you want me to transition them manually, test them and commit them? Let me know. |
|
The two files that are failing have been transitioned, at least attempted:
The files with node connection errors are the other ones listed on this page, including:
Here is an example of one of the error files. If something went wrong with transition, let me know and I'll try to fix it this morning. |
…into 75127368_DCFSEC
|
@Myoldmopar. I see the transitioned objects for indirect evaporative cooler objects after the input field "Dewpoint Effectiveness Factor" are truncated (left out). The secondary air inlet and outlet node names, and the remaining input fields are also are missing in the transitioned objects. Also the transitioned direct evaporative cooler objects are also truncated after the input field "!- Sensor Node Name". I have manually transitioned the five test files and they all run successfully here in my machine. Do you want me to push them to the remote branch? |
|
Yes, and I'll make sure the Transition code is doing the right thing On Tue, Mar 3, 2015 at 10:44 AM, Bereket Nigusse notifications@github.com
Edwin Lee, PhD |
|
@Myoldmopar. Committed the five test files. |
|
OK, CI will run and I'll check out the transition source. |
|
@Myoldmopar Sounds like \min-fields may need to be changed for those objects to transition properly? |
|
@Myoldmopar And remember I'm still planning to modify to 2zone data center example fiile once the systotcap fix in merged in here (or did that happen already and I missed it?) |
|
That did already happen, go ahead and make the change to this branch. |
|
@Nigusse So updating those files in db026d7 might have helped them run, but it seemed to undo some of the things Transition had cleaned up previously. The system sizing objects got the new fields truncated down, so the input processor is now filling them with defaults, and lots of comments are reverted. There will definitely need to be a follow-up to clean up those files (along with the change @mjwitte wants to make to the example file), but after those are done, I do think this is close. I'll wait to merge develop into this branch until we get those issues worked out. |
|
May be I have to revert the five test files that I committed yesterday and update only the evaporative cooler objects changes individually and re-commit them. Is that okay with you? |
|
That's perfect; thank you.
|
|
@Myoldmopar @mjwitte Cleaned up the four test files and committed to the remote branch. Only four them needed cleanup, I think. |
|
@Myoldmopar @Nigusse Fixed some errors with the IDD and ITE get input. I have a modified version of 2ZoneDataCenterHVAC_wEconomizer that uses the ITE object instead of the generic electric equipment object, but it fails in June on an annual run, so I am reluctant to commit it. I can keep working on that here or perhaps that should be moved to a new issue so this can be merged at CI tests the fix commit? |
…erPower failure on Linux CI which does not fail on Win64 local
|
New issue #4773 opened to resolve the 2ZoneDataCenterHVAC_wEconomizer problems with ITE object. Leaving 2ZoneDataCenterHVAC_wEconomizer as-is for now with simple ElectricEquipment so this branch can get in after CI reports back. |
|
@Myoldmopar Unit test fixed. Ready for your final review and merge. |
Thanks @mjwitte for all the efforts on those last commits getting everything working well. This looks good now. Merging...
Myoldmopar
changed the title
Creating a pull request to start conversation to get this merged.