-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reintegrate_ufs #589
reintegrate_ufs #589
Conversation
to ensure they comply with the limits of the nameslist.
Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket #209 * Additional CALTYPE namelist parameter in MISC section * New ww3_tc1 regtest.
* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole. * Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.
Updates to allow a coupling time step that is different from the model time step. * Includes new regtest (in ww3_tp2.14) for non-default oasis time step. * ww3_tp2.14 regtest added to matrix.base.
This reverts commit 6efe9bb.
@aliabdolali can you please re-create this from a clean branch (without the multiple " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-create this branch with a cleaner commit history so a non-squash merge can be used.
Pull Request Summary
mask_value_land
if present in nems.configure andmed_present
is true.Description
Currently, when used in UWM, wmesmf sets the import and export mask values for the grid from the default values.
These values are opposite the normal interpretation and CMEPS is then forced to set the dstMaskValue and srcMaskValues used for RH creation opposite to their normal sense. In med_map_mod, the currently used values in CMEPS for HAFS are (
n1
is the source side andn2
is the destination side)Both the
dstMaskValue
when the destination is compwav and thesrcMaskValue
when compwav is the source are reversed. That is, the dstMaskValue should indicate where the wave grid is masked when it is the destination. It should be 0 (ie, don't interpolate to the land points). The srcMaskValue should indicate what points to ignore when wave is the source. It should be 0 (ie, don't interpolate from land points on the wave grid).When HAFS is switched to the new cap, the mask values will be set with the correct interpretation for CMEPS. A PR for CMEPS # 266 is the first step in implementing the new wave cap in UWM. In order for the existing cap to continue to work for HAFS, it is required to allow non-default mask values to be set from nems.configure:
These will be consistent with the
dstMaskValue
andsrcMaskValue
used by CMEPS.These configuration variables will not be added to the HAFS nems.configure in UWM until CMEPS is also updated.
fixes ufs-community/ufs-weather-model#824
This PR allows the current wmesmf cap to continue to function for UFS HAFS apps during the transition to a CMEPS cap for both S2SW and HAFS.
authors: @DeniseWorthen @junwang-noaa
Commit Message
Check list
Testing
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt