Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESMF managed threading code #587

Merged

Conversation

junwang-noaa
Copy link
Contributor

Pull Request Summary

This PR make the SetVM public which is required to enable ESMF managed threading

Description

Issue(s) addressed

fixes ufs-community/ufs-weather-model#824

Commit Message

Check list

Testing

  • How were these changes tested?
    The code change is tested in ufs-weather-model on hera
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    A future test will be added, at this time, it is just to enable the ESMF managed threading development
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
  • Please indicate the expected changes in the regression test output (Note the known list of non-identical tests).
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@aliabdolali
Copy link
Contributor

The ufs-weather-model regtests have been successful on hera with the WW3/ufs-weather-model with these changes.
WW3 standalone regtests ran successfully and a PR is made to the develop branch #589

@aliabdolali aliabdolali self-requested a review January 24, 2022 03:08
@aliabdolali aliabdolali merged commit 1af207d into NOAA-EMC:dev/ufs-weather-model Jan 24, 2022
aliabdolali pushed a commit to aliabdolali/WW3 that referenced this pull request Jan 25, 2022
aliabdolali pushed a commit that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants