Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable model to run based on a climate simulation 360 day calendar #209

Closed
ukmo-ansaulter opened this issue Jun 8, 2020 · 6 comments
Closed

Enable model to run based on a climate simulation 360 day calendar #209

ukmo-ansaulter opened this issue Jun 8, 2020 · 6 comments
Assignees
@ukmo-ansaulter @ukmo-juan-castillo
Labels
enhancement New feature or request

Comments

@ukmo-ansaulter
Copy link
Collaborator

Add an input namelist option to switch between 365 day + leap year, and 360 day calendars
@ukmo-ansaulter ukmo-ansaulter added the enhancement New feature or request label Jun 8, 2020
@ukmo-ansaulter ukmo-ansaulter self-assigned this Jun 8, 2020
@ukmo-juan-castillo
Copy link
Collaborator

I will be in charge of implementing the changes.

@ukmo-ansaulter
Copy link
Collaborator Author

Thanks @ukmo-juan-castillo

Anticipating that changes will be provided to (at least):

  • w3timemd.ftn
  • ww3_grid.ftn
  • ww3_ounf.ftn

For ww3_ounf we will need to ensure that the time metadata will be updated in compliance with CF conventions, see http://cfconventions.org/cf-conventions/cf-conventions.html#calendar

We also need to consider whether adding the 360 day calendar is in scope for the grib conversion software and point spectral formats

@ukmo-juan-castillo
Copy link
Collaborator

This change will be implemented in the branch fb_360_calendar. A new flag in the RUN_NML namelist called F360CAL will be used to decide if the 360-day calendar is to be used or not.

ukmo-juan-castillo added a commit to ukmo-waves/WW3 that referenced this issue Jun 24, 2020
@ukmo-juan-castillo
Changes to add support to 360-day calendar - see ticket NOAA-EMC#209
48d311d 
NOAA-EMC#209
At this point, only code changes are added. Code functionality is
already tested, regtests not run yet.
@ukmo-juan-castillo
Copy link
Collaborator

It was decided that the flag indicating the 360-day calendar will be moved to the MISC namelist for ww3_grid, at the same location where the NOLEAP flag is placed. There will be a check to avoid setting the NOLEAP and the new CAL360 flags to .TRUE. at the same time, as they determine different calendars (365-day without leap year, and 360-day respectively)

@ukmo-juan-castillo
Copy link
Collaborator

A new regtest has been included in ww3_ts1 to check that the new 360-day calendar is behaving as expected.

This was referenced Jul 7, 2020
Closed
Merged
ukmo-juan-castillo added a commit to ukmo-waves/WW3 that referenced this issue Jul 9, 2020
@ukmo-juan-castillo
Changes to add support to 360-day calendar - see ticket NOAA-EMC#209
fdf274c 
NOAA-EMC#209
At this point, only code changes are added. Code functionality is
already tested, regtests not run yet.
ukmo-ccbunney pushed a commit to ukmo-waves/WW3 that referenced this issue Jul 16, 2020
@ukmo-juan-castillo
Fb 360 calendar (#8)
303b3a9 
Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket NOAA-EMC#209
  * Additional CALTYPE namelist parameter in MISC section
  * New ww3_tc1 regtest.
ukmo-ccbunney pushed a commit to ukmo-waves/WW3 that referenced this issue Jul 22, 2020
@ukmo-juan-castillo @ukmo-ccbunney
Fb 360 calendar (#8)
71b9ba9 
Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket NOAA-EMC#209
  * Additional CALTYPE namelist parameter in MISC section
  * New ww3_tc1 regtest.
@ukmo-juan-castillo
Copy link
Collaborator

This enhancement has already been successfully implemented, tested, and merged in the staging branch of the ukmo-waves repository.

aliabdolali added a commit that referenced this issue Aug 10, 2020
@aliabdolali @UKMO-lsampson
@ukmo-juan-castillo @ukmo-ccbunney
UKMO staging [develop] #237 (#241)
60f0fdf 
* Added boundary checks to the SMC grid input files for ww3_grid,
to ensure they comply with the limits of the nameslist.

* Fb 360 calendar (#8)

Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket #209
  * Additional CALTYPE namelist parameter in MISC section
  * New ww3_tc1 regtest.

* RTD support for ww3_boun[dc] (#10)

* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole.
* Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.

* Fb coupling time (#9)

Updates to allow a coupling time step that is different from the model time step. 
* Includes new regtest (in ww3_tp2.14) for non-default oasis time step.
* ww3_tp2.14 regtest added to matrix.base.

* bug fix for ukmet development

Co-authored-by: lewis.sampson <lsampson@vld240.cmpd1.metoffice.gov.uk>
Co-authored-by: Juan Manuel Castillo Sanchez <48921434+ukmo-juan-castillo@users.noreply.github.com>
Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com>
aliabdolali added a commit that referenced this issue Oct 20, 2020
@aliabdolali @UKMO-lsampson
@ukmo-juan-castillo @ukmo-ccbunney
Bugfix trnc (#260)
993a431 
* Added boundary checks to the SMC grid input files for ww3_grid,
to ensure they comply with the limits of the nameslist.

* Fb 360 calendar (#8)

Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket #209
  * Additional CALTYPE namelist parameter in MISC section
  * New ww3_tc1 regtest.

* RTD support for ww3_boun[dc] (#10)

* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole.
* Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.

* Fb coupling time (#9)

Updates to allow a coupling time step that is different from the model time step. 
* Includes new regtest (in ww3_tp2.14) for non-default oasis time step.
* ww3_tp2.14 regtest added to matrix.base.

* bug fix for ukmet development

* see issue #245

this is a bug introduced with the last PR from UKMO
ukmo-waves#8: 360 day climate calendar

in ww3_trnc.ftn
END CASE
should be replaced by
END SELECT

Co-authored-by: lewis.sampson <lsampson@vld240.cmpd1.metoffice.gov.uk>
Co-authored-by: Juan Manuel Castillo Sanchez <48921434+ukmo-juan-castillo@users.noreply.github.com>
Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com>
aliabdolali added a commit that referenced this issue Jan 13, 2021
@aliabdolali @UKMO-lsampson
@ukmo-juan-castillo @ukmo-ccbunney
Feature/gfsprod (#297)
7fa771b 
* Added boundary checks to the SMC grid input files for ww3_grid,
to ensure they comply with the limits of the nameslist.

* Fb 360 calendar (#8)

Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket #209
  * Additional CALTYPE namelist parameter in MISC section
  * New ww3_tc1 regtest.

* RTD support for ww3_boun[dc] (#10)

* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole.
* Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.

* Fb coupling time (#9)

Updates to allow a coupling time step that is different from the model time step. 
* Includes new regtest (in ww3_tp2.14) for non-default oasis time step.
* ww3_tp2.14 regtest added to matrix.base.

* bug fix for ukmet development

* Updating develop with a change to allow code build using non-standard NetCDF libraries using alphabetical characters in their version name.

Co-authored-by: lewis.sampson <lsampson@vld240.cmpd1.metoffice.gov.uk>
Co-authored-by: Juan Manuel Castillo Sanchez <48921434+ukmo-juan-castillo@users.noreply.github.com>
Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com>
Co-authored-by: Ali Abdolali <aliabdolali@Alis-MBP.fios-router.home>
aliabdolali added a commit that referenced this issue Mar 22, 2021
@aliabdolali @UKMO-lsampson
@ukmo-juan-castillo @ukmo-ccbunney @sbrus89 @menta78
Fb_global_unstr (#335)
854fc86 
* Added boundary checks to the SMC grid input files for ww3_grid,
to ensure they comply with the limits of the nameslist.

* Fb 360 calendar (#8)

Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket #209
  * Additional CALTYPE namelist parameter in MISC section
  * New ww3_tc1 regtest.

* RTD support for ww3_boun[dc] (#10)

* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole.
* Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.

* Fb coupling time (#9)

Updates to allow a coupling time step that is different from the model time step. 
* Includes new regtest (in ww3_tp2.14) for non-default oasis time step.
* ww3_tp2.14 regtest added to matrix.base.

* bug fix for ukmet development

* Periodicity fix for global unstructured grids

 - Corrects calculation of element areas and edge lengths across the
   dateline in w3triamd.ftn

 - Fixes calculation to determine whether a point is inside an element
   that spans the dateline in w3triamd.ftn

 - Corrects calculation of element centers and corners across dateline
   in wmscrpmd.ftn

 - Write out SCRIP file in netCDF format at the end of ww3_grid
   (for creating offline remaping files). This required adding netCDF support
   to ww3_grid

 - Also includes minor fix for the /O7a switch in w3iopomd.ftn

* modify the model/ftn/w3triamd.ftn and model/ftn/wmscrpmd.ftn and change from global grids from min(longitude)=-180, max(longitude)=180 to \delta(longitude)=360 degrees and added the regression test ww3_tp2.21

* bug fix for ww3_grid make without SCRIP switch

* Fix for corner node periodicity in wmscrpmd.ftn

* PDLIB/yowpdlibmain.ftn: fix to handle global meshes

* bug fix for SCRIPNC switch

* update info for ww3_tp2.21 for domain decomposition and PDLIB option

* fix for mww3_04 link with SCRIP and SCRIPNC switch

* add inputs to tar file, update model/bin/ww3_from_ftp.sh and remove inputs from ww3_tp2.21

* reduce the duration of ww3_tp2.21 for the sake of regtest time

* small editorial fixes

* fixes for SCRIPNC switch

* change date for ww3_ounf and ww3_ounp for ww3_tp2.21

* edit w3_make

Co-authored-by: lewis.sampson <lsampson@vld240.cmpd1.metoffice.gov.uk>
Co-authored-by: Juan Manuel Castillo Sanchez <48921434+ukmo-juan-castillo@users.noreply.github.com>
Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com>
Co-authored-by: Ali Abdolali <aliabdolali@Alis-MBP.fios-router.home>
Co-authored-by: Steven Brus <sbrus@lanl.gov>
Co-authored-by: Steven Brus <steven.r.brus@gmail.com>
Co-authored-by: Lorenzo Mentaschi <lorenzo.mentaschi@unige.it>
aliabdolali added a commit that referenced this issue Mar 24, 2021
@aliabdolali @UKMO-lsampson
@ukmo-juan-castillo @ukmo-ccbunney
Fb matrix divider (#328)
78b0148 
* Added boundary checks to the SMC grid input files for ww3_grid,
to ensure they comply with the limits of the nameslist.

* Fb 360 calendar (#8)

Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket #209
  * Additional CALTYPE namelist parameter in MISC section
  * New ww3_tc1 regtest.

* RTD support for ww3_boun[dc] (#10)

* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole.
* Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.

* Fb coupling time (#9)

Updates to allow a coupling time step that is different from the model time step. 
* Includes new regtest (in ww3_tp2.14) for non-default oasis time step.
* ww3_tp2.14 regtest added to matrix.base.

* bug fix for ukmet development

* add the matrix subsetter

* clean-up

* clean up

* add another script which separate serial and parallel jobs and divide them

* modify the script to remove ../model? after test completion.

* bug fixes and adding ww3_tp2.17 to list_heavy

* add if statement to remove matrix? and model?

* Update matrix_divider_p.sh

* Merge remote-tracking branch 'upstream/develop' into fb_matrix_divider

* Merge remote-tracking branch 'upstream/develop' into fb_matrix_divider

* put if check for ../model? inside matrix? loop

* fix the bug for sed for model?

* final fix for extra model? removal

* add 2.21 to the list_heavy

Co-authored-by: lewis.sampson <lsampson@vld240.cmpd1.metoffice.gov.uk>
Co-authored-by: Juan Manuel Castillo Sanchez <48921434+ukmo-juan-castillo@users.noreply.github.com>
Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com>
Co-authored-by: Ali Abdolali <aliabdolali@Alis-MBP.fios-router.home>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukmo-ansaulter ukmo-ansaulter

@ukmo-juan-castillo ukmo-juan-castillo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ukmo-ansaulter @ukmo-juan-castillo