UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates)

[SamuelTrahanNOAA]

Updates UPP to be compatible with the ufs-weather-model inline post. Also fixes a bug that produced thousands of error messages from g2tmpl.

This was originally a PR to add number concentration on pressure levels, but I had to fix those unrelated bugs to get this in the ufs-weather-model.

• fixes extraneous GSD_ in number concentration variable names #972
• fixes number concentration on pressure levels #973
• fixes Some variables are missing from DEALLOCATE.f #975
• fixes Numerous "255 not found in table 4.5" errors from UPP #978

[SamuelTrahanNOAA]

The GCC Linux Build is failing due to an error in a spack stack script:

/home/runner/work/UPP/UPP/spack/lib/spack/env/gcc/gcc: 246: [[: not found

The script is a bash script, but claims to be sh. Hence, sh is rejecting the line with the optional feature [[. This script was probably developed on an RedHat-like system, and never tested with a more limited /bin/sh found on most other UNIX variants.

You must either add this as the first line:

#! /bin/bash

or rewrite the script to use only POSIX sh without its optional features.

[WenMeng-NOAA]

@SamuelTrahanNOAA Can you provide model output in netcdf for my UPP standalone test?

[SamuelTrahanNOAA]

Can you provide model output in netcdf for my UPP standalone test?

For testing what, specifically?

[WenMeng-NOAA]

Can you provide model output in netcdf for my UPP standalone test?

For testing what, specifically?

Run your branch with *hafs_ar_*control file to generate grib2 file including these number concentrations on pressure levels.

[SamuelTrahanNOAA]

EDIT: I have fixed the problem described in this comment.

The problem that was fixed.

Presently, the UPP won't run my latest txt file because the xml_perl_data.f can't read the output of PostXMLPreprocessor.pl.

221: forrtl: severe (59): list-directed I/O syntax error, unit 22, file /scratch1/NCEPDEV/stmp2/Samuel.Trahan/FV3_RT/rt_2870606/gnv1_nested_intel/postxconfig-NT_FH00.txt
221: Image              PC                Routine            Line        Source
221: fv3.exe            00000000048C0BE8  Unknown               Unknown  Unknown
221: fv3.exe            00000000048FDA02  Unknown               Unknown  Unknown
221: fv3.exe            00000000048FC467  Unknown               Unknown  Unknown
221: fv3.exe            000000000401343F  xml_perl_data_mp_         290  xml_perl_data.f
221: fv3.exe            0000000003F0FAB9  read_xml_                  59  READ_xml.f
221: fv3.exe            000000000226FEB5  post_fv3_mp_post_         162  post_fv3.F90
221: fv3.exe            000000000222E842  module_wrt_grid_c        2036  module_wrt_grid_comp.F90

It fails here:

            read(22,*)paramset(i)%param(j)%scale_fact_1st_size
            read(22,*)paramset(i)%param(j)%scale_val_1st_size
            read(22,*)paramset(i)%param(j)%scale_fact_2nd_size
            read(22,*)paramset(i)%param(j)%scale_val_2nd_size    ! <----- fails here
            read(22,*)paramset(i)%param(j)%typ_intvl_wvlen
              call filter_char_inp(paramset(i)%param(j)%typ_intvl_wvlen)

[SamuelTrahanNOAA]

This may be due to problems in my regression test changes. I'll investigate and report back soon...

EDIT: It was, but I have a new problem!

[SamuelTrahanNOAA]

EDIT: I have fixed the problem described in this comment.

The problem that has been fixed.

My regression test was using an older postxconfig file.

Now the inline post is failing due to missing deallocates:

• Some variables are missing from DEALLOCATE.f #975

I've fixed that, and now I seek the next bug...

[SamuelTrahanNOAA]

@WenMeng-NOAA - Do you know why the inline post is making this complaint? I'm seeing a lot of them.

234:  get_g2_fixedsurfacetypes key:          255  not found in table 4.5

You can find the output here:

LOG: /scratch1/NCEPDEV/stmp2/Samuel.Trahan/FV3_RT/rt_3037467/gnv1_nested_intel.log
RUN: /scratch1/NCEPDEV/stmp2/Samuel.Trahan/FV3_RT/rt_3037467/gnv1_nested_intel

Many ranks give the same error many times, but it's always the same error.

[SamuelTrahanNOAA]

Code is here:

ufs-community/ufs-weather-model#2326

The regression test is gnv1_nested, but you can only run on Hera. Other machines don't have g2tmpl 1.12.0 in the same Spack Stack as ufs-weather-model prerequisites.

[WenMeng-NOAA]

@SamuelTrahanNOAA Can you sync your branch with the UPP develop?

[WenMeng-NOAA]

The GCC Linux Build is failing due to an error in a spack stack script:

/home/runner/work/UPP/UPP/spack/lib/spack/env/gcc/gcc: 246: [[: not found

The script is a bash script, but claims to be sh. Hence, sh is rejecting the line with the optional feature [[. This script was probably developed on an RedHat-like system, and never tested with a more limited /bin/sh found on most other UNIX variants.

You must either add this as the first line:

#! /bin/bash

or rewrite the script to use only POSIX sh without its optional features.

@AlexanderRichert-NOAA Could you add the fix per @SamuelTrahanNOAA 's suggestion? Thanks!

[WenMeng-NOAA]

@WenMeng-NOAA - Do you know why the inline post is making this complaint? I'm seeing a lot of them.

234:  get_g2_fixedsurfacetypes key:          255  not found in table 4.5

You can find the output here:

LOG: /scratch1/NCEPDEV/stmp2/Samuel.Trahan/FV3_RT/rt_3037467/gnv1_nested_intel.log RUN: /scratch1/NCEPDEV/stmp2/Samuel.Trahan/FV3_RT/rt_3037467/gnv1_nested_intel

Many ranks give the same error many times, but it's always the same error.

@SamuelTrahanNOAA Is this test for global or regional domain?

[WenMeng-NOAA]

RUN: /scratch1/NCEPDEV/stmp2/Samuel.Trahan/FV3_RT/rt_3037467/gnv1_nested_intel

@SamuelTrahanNOAA Can you update itag in the run directory as

&MODEL_INPUTS
 MODELNAME='FV3R'
/
&NAMPGB
KPO=47,PO=1000.,975.,950.,925.,900.,875.,850.,825.,800.,775.,750.,725.,700.,675.,650.,625.,600.,575.,550.,525.,500.,475.,450.,425.,400.,375.,350.,325.,300.,275.,250.,225.,200.,175.,150.,125.,100.,70.,50.,30.,20.,10.,7.,5.,3.,2.,1.,
/

[climbfuji]

@SamuelTrahanNOAA The bug fix for the spack wrapper was merged. Submodule pointer update for spack-stack will follow this morning. Thanks for figuring this out. I had tested on Ubuntu, macOS, Oracle Linux and CentOS (both Red Hat derivates). What system is UPP CI running on?

[SamuelTrahanNOAA]

Is this test for global or regional domain?

"And," not "or."

There's a globe with a regional nest.

[SamuelTrahanNOAA]

Can you update itag in the run directory as

I think you're telling me the pressure levels in itag don't match the xml. That is because I started with the HAFS xml, but forgot to update the pressure levels. I'm going to make the opposite change to what you suggest: copy the GFS pressure levels into the hafs_ar xml.

EDIT: I meant to type "hafs_ar xml." This has been corrected.

[WenMeng-NOAA]

@SamuelTrahanNOAA The bug fixes were implemented in the RRFS branch 'release/rrfs_v1' to solve the issue of unduplicated RRFS grib2 metadata. I will submit a PR to sync these changes to the develop branch before your PR is processed.

[SamuelTrahanNOAA]

The bug fixes were implemented in the RRFS branch 'release/rrfs_v1' to solve the issue of unduplicated RRFS grib2 metadata.

@WenMeng-NOAA - I looked at #979 and I don't see any of the bug fixes from this PR in that one. There are bug fixes, but they're entirely unrelated and do not overlap.

[WenMeng-NOAA]

The bug fixes were implemented in the RRFS branch 'release/rrfs_v1' to solve the issue of unduplicated RRFS grib2 metadata.

@WenMeng-NOAA - I looked at #979 and I don't see any of the bug fixes from this PR in that one. There are bug fixes, but they're entirely unrelated and do not overlap.

@SamuelTrahanNOAA The bug fixes in #797, first implemented in the develop branch, will ensure to the generation of consistent grib2 metadata in RRFS dataset.
example for QPFFG in PRSLEV:

test1:
< 772:4824832913:vt=2024022023:surface:11-12 hour acc fcst:var discipline=1 center=7 local_table=1 parmcat
=1 parm=197:prob >1:prob fcst 72/110
test2:
772:4824832913:vt=2024022023:surface:11-12 hour acc fcst:var discipline=1 center=7 local_table=1 parmcat
=1 parm=197:prob >1:prob fcst 96/110
6177c6177

[WenMeng-NOAA]

@SamuelTrahanNOAA Can you sync your branch with the latest UPP develop? We will process your PR.

[SamuelTrahanNOAA]

Before you merge this, I want to confirm the inline post works after I update the branch.

[WenMeng-NOAA]

Before you merge this, I want to confirm the inline post works after I update the branch.

@SamuelTrahanNOAA Sure. Right now, we would like you to sync your branch so we can run the UPP RTs.

[SamuelTrahanNOAA]

My branch is updated and the inline post seems to work. (Hera queues were unusually fast today.) This branch is ready for regression testing.

[WenMeng-NOAA]

The UPP RTs were completed on WCOSS2 without baseline changes.

[WenMeng-NOAA]

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline update in this PR.

[FernandoAndrade-NOAA]

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline update in this PR.

Permission restrictions on the branch prevent me from pushing RT logs, but there are no changes in RT results on Hera and Hercules. Looks good from my side.

[WenMeng-NOAA]

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline update in this PR.

Permission restrictions on the branch prevent me from pushing RT logs, but there are no changes in RT results on Hera and Hercules. Looks good from my side.

@SamuelTrahanNOAA Can you give access permission to @FernandoAndrade-NOAA so the UPP RT logs can be pushed in your branch?

[SamuelTrahanNOAA]

Can you give access permission to @FernandoAndrade-NOAA so the UPP RT logs can be pushed in your branch?

@FernandoAndrade-NOAA - I invited you as a collaborator to my repository so you can push logs to it. Please check the email connected to your github account for an invitation email. If you accept the invitation, github should let you push logs.

[FernandoAndrade-NOAA]

Thanks! We should be good to go for merging, @WenMeng-NOAA

[WenMeng-NOAA]

@SamuelTrahanNOAA Can you confirm this PR is working in inline post at ufs-weather-model side before we merge it?

[SamuelTrahanNOAA]

Can you confirm this PR is working in inline post at ufs-weather-model side before we merge it?

The ufs-weather-model baseline generation ran without incident. I didn't check the GRIB files's contents since there are hundreds of them, with thousands of records in each.

[SamuelTrahanNOAA]

The ufs-weather-model code managers will run the regression tests on all supported platforms sometime in the next few weeks. At that point, we'll have broader assurances that the inline post works. However, they don't run regression tests until subcomponent pull requests are merged, including this one. That means you must merge this pull request before we can do large-scale testing of the inline post across all platforms.

[WenMeng-NOAA]

@SamuelTrahanNOAA We can merge this PR now and address inline post issues later if needed.

[WenMeng-NOAA]

This PR is ready for merging.