Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable template 4-49 to obtain aerosol ensemble information #1011

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

lipan-NOAA
Copy link
Contributor

#1009

In order to compile this update correctly, please update the g2tmpl library in the module file

@lipan-NOAA
Copy link
Contributor Author

@WenMeng-NOAA The code update PR has been submitted, please review it.

@WenMeng-NOAA WenMeng-NOAA added enhancement New feature or request GEFSV13 labels Aug 12, 2024
@WenMeng-NOAA
Copy link
Collaborator

@lipan-NOAA The g2/3.5.1 and g2tmpl/1.13.0 are available on WCOSS2 and R&D platforms now. Can you update relevant modulefiles in your branch?

@WenMeng-NOAA
Copy link
Collaborator

@lipan-NOAA Can you also update the following gefs aerosol/chem control file under parm/gefs for gefs v13 products?

postcntrl_gefs_chem.xml and postxconfig-NT-gefs-chem.txt
postcntrl_gefs_aerosol_f00.xml and postxconfig-NT-gefs-f00-aerosol.txt
postcntrl_gefs_aerosol.xml and postxconfig-NT-gefs-aerosol.txt

@lipan-NOAA
Copy link
Contributor Author

@WenMeng-NOAA I will update these later if possible as I still need to discuss with the GEFS team about the setup of the aerosol products in GEFS

@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Aug 13, 2024
@WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA I will update these later if possible as I still need to discuss with the GEFS team about the setup of the aerosol products in GEFS

@lipan-NOAA Your plan sounds good to me. We will wrap your PR for processing.

@WenMeng-NOAA
Copy link
Collaborator

@lipan-NOAA I did an UPP standalone test with model output from GEFS v13 EP5r2 and control file "postxconfig-NT-gefs-aerosol.txt". My test results are at /u/wen.meng/ptmp/post_gefs_2018081600 on Cactus. Can you take a look at my test? Thanks!

@lipan-NOAA
Copy link
Contributor Author

@WenMeng-NOAA it looks fine to me. Thanks.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on R&D machines. There should be no baseline update in this PR.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have been completed on WCOSS2. No baseline update is needed in this PR.

Copy link
Collaborator

@FernandoAndrade-NOAA FernandoAndrade-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results showed no changes across Hera, Hercules, and Orion. Failures in GCC CI build will likely continue until packages can be updated to 3.5.1 and 1.13.0

@SamuelTrahanNOAA
Copy link
Contributor

The ufs-weather-model needs to support GCC. We'll have to get the GCC builds working before ufs-community/ufs-weather-model#2326 can be merged.

Failures in GCC CI build will likely continue until packages can be updated to 3.5.1 and 1.13.0

@WenMeng-NOAA
Copy link
Collaborator

Results showed no changes across Hera, Hercules, and Orion. Failures in GCC CI build will likely continue until packages can be updated to 3.5.1 and 1.13.0

@FernandoAndrade-NOAA The GCC failure in GCC CI was on github. I am not sure if any updates are needed for the configuration of CI on github. Can you test the UPP standalone with GCC on Hera or Orion?

@FernandoAndrade-NOAA
Copy link
Collaborator

I can't confirm in the case of manual testing until the gnu spack-stack has been updated with g2 3.5.1 and g2tmpl 1.13.0

@SamuelTrahanNOAA
Copy link
Contributor

If the gnu spack-stack hasn't been updated yet, then that is a confirmation that it doesn't work.

@FernandoAndrade-NOAA
Copy link
Collaborator

This was on Hera, which may be one of the machines with version conflicts Ratko mentioned, let me try Orion if it's available and as a pretest if there's going to be any issues.

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA @FernandoAndrade-NOAA The UPP build script under tests/compile_upp.sh doesn't include configuration for building executable with GCU compiler.
@FernandoAndrade-NOAA Can you share with me your build script with GNU compiler on Hera?

@WenMeng-NOAA
Copy link
Collaborator

I saw g2/3.5.1 and g2tmpl/1.13.0 are available at /scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.6.0/envs/upp-addon-env/install/modulefiles/gcc/9.2.0 for GNU compiler on Hera. It appears to me the failure of @FernandoAndrade-NOAA 's testing might be finding the latest g2 and g2tmpl at the appropriate spack-stack location. That issue could be addressed in the UFS PR #2326.

@WenMeng-NOAA WenMeng-NOAA merged commit 81b38a8 into NOAA-EMC:develop Aug 13, 2024
2 of 3 checks passed
@WenMeng-NOAA WenMeng-NOAA linked an issue Aug 15, 2024 that may be closed by this pull request
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this pull request Sep 9, 2024
* origin/develop:
  Updates to support MPAS applications (RRFS and HFIP) (NOAA-EMC#1029)
  Add 6-hrly max winds at 10m to SFS (NOAA-EMC#1019)
  Update jet.lua (NOAA-EMC#1027)
  Updates to support UPP use with MPAS (NOAA-EMC#1018)
  [develop]: Turn on WARN_AS_ERROR for Doxygen Documentation Builds (NOAA-EMC#1023)
  Sample PR for testing (NOAA-EMC#1007)
  Enable template 4-49 to obtain aerosol ensemble information (NOAA-EMC#1011)
  Relocate gfs/gefs/sfs control files (NOAA-EMC#990)
  update g2tmp on aws to 1.12.0 (NOAA-EMC#996)
  [develop]: Update requirements files (NOAA-EMC#994)
  Bump zipp from 3.17.0 to 3.19.1 in /doc/UserGuide (NOAA-EMC#991)
  remove stack-python load for Gaea build (NOAA-EMC#993)
  Bump certifi from 2024.2.2 to 2024.7.4 in /doc/UserGuide (NOAA-EMC#988)
  [develop]: Add Doxygen variable definitions to modules (NOAA-EMC#965)
  Read bucket either as an integer or float (NOAA-EMC#984)
  Update Orion module file for Rocky 9 upgrade (NOAA-EMC#987)
  UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates) (NOAA-EMC#974)
  Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968. (NOAA-EMC#979)
  Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UserGuide (NOAA-EMC#981)
  Fix for hydrostatic runs - write out Omega and HGT from model output (NOAA-EMC#959)
  Bump requests from 2.31.0 to 2.32.0 in /doc/UserGuide (NOAA-EMC#963)
  Correct rt.sh paths (NOAA-EMC#957)
  Updates to use GRIB2 template 4.9 for QPFFFG and QPFARI variables in RRFS (NOAA-EMC#929)
  Add hourly averaged smoke PM2.5 and dust PM10 (NOAA-EMC#917)
  Update Namelist documentation for all namelist options (NOAA-EMC#940)
  update gtg code revision to v.4.16.3 (NOAA-EMC#954)
  Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UserGuide (NOAA-EMC#953)
  Clean up labeling for 15-min accumulated fields (NOAA-EMC#948)
  Updates to the GSL exp1 ceiling diagnostic (NOAA-EMC#947)
  Additional RT log information (NOAA-EMC#941)
  add cmake load to modulefile/gaea.lua (NOAA-EMC#945)
  RRFS updates (NOAA-EMC#938)
  add module for AWS (NOAA-EMC#934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GEFSV13 Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added functionality to handle aerosol ensemble information in UPP
4 participants