Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up labeling for 15-min accumulated fields #948

Merged
merged 17 commits into from
May 6, 2024

Conversation

EricJames-NOAA
Copy link
Contributor

This PR includes the following changes:

(1) corrects the time labeling for the 15-min accumulated fields for RRFS
(2) switch to use "BUCKET1" fields created for the HRRR 15-min output in RRFS
(3) add sub-hourly control files to UPP repository
(4) add output of 15-min graupel (which was included in HRRR)

There will be a final update needed to read the correct (actual 15-min acccumulation) fields in SURFCE.f.

The code was tested for RRFS_NA_3km on Jet.

@WenMeng-NOAA WenMeng-NOAA linked an issue May 2, 2024 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Do you have the sample model outputs for my testing on Hera?

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA I would suggest updating the parm/makefile to add new RRFS sub-hourly control files.

@WenMeng-NOAA WenMeng-NOAA added RRFS Ready for Review This PR is ready for code review. labels May 2, 2024
@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA Do you have the sample model outputs for my testing on Hera?

Yes, I have files here:

/scratch1/BMC/wrfruc/ejames/wen_subh/

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. No baseline update is expected.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label May 6, 2024
@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs have been completed on WCOSS2.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. No baseline update is expected.

RTs completed across machines with no changes to results. Looks good to go from my side. Despite the option for maintainers to be able to make changes to the PR, I had to manually copy and paste log info due to permission issues on pushing logs, @EricJames-NOAA please double check your repository in case any repo settings are overriding push permissions.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. No baseline update is expected.

RTs completed across machines with no changes to results. Looks good to go from my side. Despite the option for maintainers to be able to make changes to the PR, I had to manually copy and paste log info due to permission issues on pushing logs, @EricJames-NOAA please double check your repository in case any repo settings are overriding push permissions.

@FernandoAndrade-NOAA Do you have the instructions for updating the settings in developer's UPP fork so that RT logs can be automatically pushed?

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit b0e574b into NOAA-EMC:develop May 6, 2024
5 checks passed
@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. No baseline update is expected.

RTs completed across machines with no changes to results. Looks good to go from my side. Despite the option for maintainers to be able to make changes to the PR, I had to manually copy and paste log info due to permission issues on pushing logs, @EricJames-NOAA please double check your repository in case any repo settings are overriding push permissions.

@FernandoAndrade-NOAA Do you have the instructions for updating the settings in developer's UPP fork so that RT logs can be automatically pushed?

I believe a quick fix for the push permissions to specific users would be to add Wen and myself as collaborators under your repo settings at the top > collaborators, that should allow us to push commits to your branches in the future.

DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this pull request Sep 9, 2024
* origin/develop:
  Updates to support MPAS applications (RRFS and HFIP) (NOAA-EMC#1029)
  Add 6-hrly max winds at 10m to SFS (NOAA-EMC#1019)
  Update jet.lua (NOAA-EMC#1027)
  Updates to support UPP use with MPAS (NOAA-EMC#1018)
  [develop]: Turn on WARN_AS_ERROR for Doxygen Documentation Builds (NOAA-EMC#1023)
  Sample PR for testing (NOAA-EMC#1007)
  Enable template 4-49 to obtain aerosol ensemble information (NOAA-EMC#1011)
  Relocate gfs/gefs/sfs control files (NOAA-EMC#990)
  update g2tmp on aws to 1.12.0 (NOAA-EMC#996)
  [develop]: Update requirements files (NOAA-EMC#994)
  Bump zipp from 3.17.0 to 3.19.1 in /doc/UserGuide (NOAA-EMC#991)
  remove stack-python load for Gaea build (NOAA-EMC#993)
  Bump certifi from 2024.2.2 to 2024.7.4 in /doc/UserGuide (NOAA-EMC#988)
  [develop]: Add Doxygen variable definitions to modules (NOAA-EMC#965)
  Read bucket either as an integer or float (NOAA-EMC#984)
  Update Orion module file for Rocky 9 upgrade (NOAA-EMC#987)
  UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates) (NOAA-EMC#974)
  Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968. (NOAA-EMC#979)
  Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UserGuide (NOAA-EMC#981)
  Fix for hydrostatic runs - write out Omega and HGT from model output (NOAA-EMC#959)
  Bump requests from 2.31.0 to 2.32.0 in /doc/UserGuide (NOAA-EMC#963)
  Correct rt.sh paths (NOAA-EMC#957)
  Updates to use GRIB2 template 4.9 for QPFFFG and QPFARI variables in RRFS (NOAA-EMC#929)
  Add hourly averaged smoke PM2.5 and dust PM10 (NOAA-EMC#917)
  Update Namelist documentation for all namelist options (NOAA-EMC#940)
  update gtg code revision to v.4.16.3 (NOAA-EMC#954)
  Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UserGuide (NOAA-EMC#953)
  Clean up labeling for 15-min accumulated fields (NOAA-EMC#948)
  Updates to the GSL exp1 ceiling diagnostic (NOAA-EMC#947)
  Additional RT log information (NOAA-EMC#941)
  add cmake load to modulefile/gaea.lua (NOAA-EMC#945)
  RRFS updates (NOAA-EMC#938)
  add module for AWS (NOAA-EMC#934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable 15-min QPF output in RRFS
3 participants