Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement attachments #4131

Merged
merged 33 commits into from
Jun 16, 2023
Merged

Implement attachments #4131

merged 33 commits into from
Jun 16, 2023

Conversation

ce-simsoft
Copy link
Contributor

@ce-simsoft ce-simsoft commented Nov 3, 2022 •
edited by gjvoosten
Loading

ANET supports attachments that can be linked to reports.

Closes #23, AB#222, AB#223

User changes

  • Can upload, download and edit attachments as part of a report.

Super User changes

  • none

Admin changes

  • none

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@ce-simsoft ce-simsoft force-pushed the AB-221-implement-attachments branch 2 times, most recently from 1f4c6e9 to 40025f0 Compare November 3, 2022 10:56
@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2022

This pull request introduces 2 alerts when merging 40025f0 into 899f6e2 - view on LGTM.com

new alerts:

  • 1 for Unused classes and interfaces
  • 1 for Useless parameter

@ce-simsoft ce-simsoft marked this pull request as draft November 3, 2022 11:35
gjvoosten
gjvoosten requested changes Nov 3, 2022
View reviewed changes
src/main/resources/migrations.xml Outdated Show resolved Hide resolved
src/main/java/mil/dds/anet/AnetApplication.java Outdated Show resolved Hide resolved
src/main/java/mil/dds/anet/beans/AttachmentClassification.java Outdated Show resolved Hide resolved
@ce-simsoft ce-simsoft force-pushed the AB-221-implement-attachments branch from 40025f0 to 3034d4f Compare November 4, 2022 06:45
@ce-simsoft ce-simsoft requested a review from gjvoosten November 4, 2022 06:46
@ce-simsoft ce-simsoft force-pushed the AB-221-implement-attachments branch from 3034d4f to 38489c4 Compare November 4, 2022 06:52
@lgtm-com
Copy link

lgtm-com bot commented Nov 4, 2022

This pull request introduces 2 alerts when merging 38489c4 into 2a9f81f - view on LGTM.com

new alerts:

  • 1 for Unused classes and interfaces
  • 1 for Useless parameter

midmarch
midmarch requested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security labels should be captures in the dirctionary. NU & NR are enough.

@ce-simsoft ce-simsoft force-pushed the AB-221-implement-attachments branch 3 times, most recently from 6fc9241 to 8085abc Compare November 8, 2022 11:00
@ce-simsoft ce-simsoft force-pushed the AB-221-implement-attachments branch 2 times, most recently from f9f292b to 5adc8db Compare January 11, 2023 07:49
@gjvoosten gjvoosten force-pushed the AB-221-implement-attachments branch 3 times, most recently from f3f574b to 25808f2 Compare January 26, 2023 08:50
gjvoosten
gjvoosten requested changes Jan 26, 2023
View reviewed changes
src/main/java/mil/dds/anet/beans/Attachment.java Outdated Show resolved Hide resolved
src/main/java/mil/dds/anet/database/AttachmentDao.java Show resolved Hide resolved
src/main/java/mil/dds/anet/database/AttachmentDao.java Outdated Show resolved Hide resolved
src/main/java/mil/dds/anet/database/AttachmentDao.java Show resolved Hide resolved
src/main/java/mil/dds/anet/database/AttachmentDao.java Show resolved Hide resolved
src/main/java/mil/dds/anet/resources/AttachmentResource.java Outdated Show resolved Hide resolved
src/main/java/mil/dds/anet/resources/AttachmentResource.java Outdated Show resolved Hide resolved
src/main/java/mil/dds/anet/utils/FkDataLoaderKey.java Outdated Show resolved Hide resolved
src/main/resources/migrations.xml Outdated Show resolved Hide resolved
src/main/resources/anet-schema.yml Outdated Show resolved Hide resolved
@ce-simsoft ce-simsoft force-pushed the AB-221-implement-attachments branch from 25808f2 to b32839c Compare January 27, 2023 12:51
@midmarch midmarch removed the request for review from anilsonmez-simsoft March 7, 2023 14:09
@mk-simsoft mk-simsoft force-pushed the AB-221-implement-attachments branch from b32839c to d78eb9f Compare March 21, 2023 08:15
@ce-simsoft ce-simsoft force-pushed the AB-221-implement-attachments branch 4 times, most recently from 6628b86 to bda11eb Compare March 22, 2023 07:11
mk-simsoft and others added 12 commits June 15, 2023 11:49
@mk-simsoft @gjvoosten
AB864: Change functionality of upload attachment for client-side
8b0fd4c
@mk-simsoft @gjvoosten
AB#854: Create tests for attachment client side
d9585cf
@ce-simsoft @gjvoosten
AB#866: Restrict uploading attachments
5a6813b
@gjvoosten
AB#866 Refactor attachment content upload and download
57281a4 
Also make sure only authenticated users can upload or download attachments.
Properly ellipsize the filename (even when it's shorter than 8 characters).
@gjvoosten
AB#866 Add authentication header to upload request
0b57106
@gjvoosten
AB#866 Show upload progress indicator
5b294f8
@gjvoosten
AB#866 Return negative contentLength if attachment content is absent
027f370
@gjvoosten
AB#866 Treat attachments without content differently
0ff99fc
@gjvoosten
AB#866 Set page title on attachment pages consistently
b5901da
@gjvoosten
AB#866 Clearly distinguish messages when multiple uploads are in prog…
ebe2e1c 
…ress
@gjvoosten
AB#866 Add some more nice icons for various MIME types
fbea6c7
@ce-simsoft @gjvoosten
AB#866: Update restriction
a172523
@gjvoosten gjvoosten force-pushed the AB-221-implement-attachments branch from 60dd355 to 0787da4 Compare June 15, 2023 10:13
@gjvoosten gjvoosten requested review from mk-simsoft and midmarch June 15, 2023 10:48
@gjvoosten gjvoosten force-pushed the AB-221-implement-attachments branch from 0787da4 to ed7604b Compare June 15, 2023 11:42
@ce-simsoft ce-simsoft merged commit 0d141b6 into main Jun 16, 2023
@ce-simsoft ce-simsoft deleted the AB-221-implement-attachments branch June 16, 2023 07:17
@midmarch midmarch mentioned this pull request Aug 25, 2023
Merged
14 tasks
This was referenced Aug 25, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten approved these changes

@hyesilAnka hyesilAnka Awaiting requested review from hyesilAnka

@mk-simsoft mk-simsoft Awaiting requested review from mk-simsoft

@midmarch midmarch Awaiting requested review from midmarch

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement attachments
4 participants
@ce-simsoft @gjvoosten @midmarch @mk-simsoft