Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete attachments when deleting report #4447

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Delete attachments when deleting report #4447

merged 3 commits into from
Aug 23, 2023

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Aug 9, 2023 •
edited by midmarch
Loading

Improves #4131

When a report is deleted, also delete the attachments that are linked (only) to this report.

Closes AB#912

User changes

  • No visible changes

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten marked this pull request as ready for review August 10, 2023 06:33
@gjvoosten gjvoosten force-pushed the AB-912-delete-attachments-when-deleting-report branch 2 times, most recently from d4dc38e to a10b33a Compare August 16, 2023 12:52
@gjvoosten
Add extra assertions
8b89125 
Also fix the query response from createAttachment.
@gjvoosten
AB#912 Add test for attachment deletion upon report delete
3b18bce 
Check that report attachments are deleted when a report is deleted.
@gjvoosten
AB#912 Delete report attachments when report is deleted
156fb47
@gjvoosten gjvoosten force-pushed the AB-912-delete-attachments-when-deleting-report branch from a10b33a to 156fb47 Compare August 17, 2023 06:42
@gjvoosten gjvoosten merged commit 5239b0a into main Aug 23, 2023
@gjvoosten gjvoosten deleted the AB-912-delete-attachments-when-deleting-report branch August 23, 2023 08:07
@midmarch midmarch added the internal Exclude from release change log label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyesilAnka hyesilAnka hyesilAnka approved these changes

@mk-simsoft mk-simsoft Awaiting requested review from mk-simsoft

Assignees
No one assigned
Labels
improvement internal Exclude from release change log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjvoosten @hyesilAnka @midmarch