Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to enable/disable attachment upload #4388

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Ability to enable/disable attachment upload #4388

merged 4 commits into from
Jul 12, 2023

Conversation

ce-simsoft
Copy link
Contributor

@ce-simsoft ce-simsoft commented Jul 3, 2023 •
edited by hyesilAnka
Loading

Improves #4131

Attachment feature can be enabled/disabled.

Closes AB#894

User changes

  • none

Superuser changes

  • none

Admin changes

  • Attachment feature can be enabled/disabled via dictionary

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@ce-simsoft ce-simsoft force-pushed the AB-894-permission-control-to-upload-attachments branch 2 times, most recently from cca71df to 6d039ee Compare July 4, 2023 09:42
@mk-simsoft mk-simsoft force-pushed the AB-894-permission-control-to-upload-attachments branch 4 times, most recently from eed6754 to b4fcfad Compare July 4, 2023 12:52
gjvoosten
gjvoosten requested changes Jul 5, 2023
View reviewed changes
src/main/java/mil/dds/anet/resources/AttachmentResource.java Outdated Show resolved Hide resolved
client/src/pages/reports/Show.js Outdated Show resolved Hide resolved
client/tests/webdriver/baseSpecs/showReport.spec.js Outdated Show resolved Hide resolved
client/tests/webdriver/baseSpecs/showReport.spec.js Outdated Show resolved Hide resolved
src/test/java/mil/dds/anet/test/resources/AttachmentResourceTest.java Outdated Show resolved Hide resolved
client/src/pages/reports/Form.js Outdated Show resolved Hide resolved
src/main/resources/anet-schema.yml Outdated Show resolved Hide resolved
src/test/java/mil/dds/anet/test/resources/AttachmentResourceTest.java Outdated Show resolved Hide resolved
src/test/java/mil/dds/anet/test/resources/AttachmentResourceTest.java Outdated Show resolved Hide resolved
@mk-simsoft mk-simsoft force-pushed the AB-894-permission-control-to-upload-attachments branch from 92f68ab to 7c98c79 Compare July 5, 2023 10:16
@ce-simsoft ce-simsoft force-pushed the AB-894-permission-control-to-upload-attachments branch from 7c98c79 to f59a68c Compare July 5, 2023 10:57
@ce-simsoft ce-simsoft requested a review from gjvoosten July 5, 2023 11:15
@mk-simsoft mk-simsoft self-requested a review July 7, 2023 08:10
@ce-simsoft ce-simsoft removed the request for review from mk-simsoft July 7, 2023 08:14
@gjvoosten gjvoosten force-pushed the AB-894-permission-control-to-upload-attachments branch from f59a68c to 2600705 Compare July 12, 2023 09:26
@gjvoosten gjvoosten force-pushed the AB-894-permission-control-to-upload-attachments branch from 2600705 to cd4cc64 Compare July 12, 2023 11:08
@gjvoosten gjvoosten merged commit a9a4c2b into main Jul 12, 2023
@gjvoosten gjvoosten deleted the AB-894-permission-control-to-upload-attachments branch July 12, 2023 12:37
@hyesilAnka hyesilAnka added enhancement internal Exclude from release change log and removed enhancement labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-simsoft mk-simsoft mk-simsoft left review comments

@gjvoosten gjvoosten gjvoosten approved these changes

@midmarch midmarch Awaiting requested review from midmarch

@hyesilAnka hyesilAnka Awaiting requested review from hyesilAnka

Assignees
No one assigned
Labels
improvement internal Exclude from release change log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ce-simsoft @gjvoosten @mk-simsoft @hyesilAnka