Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global status search #3125

Merged
merged 30 commits into from
Oct 29, 2020
Merged

Global status search #3125

merged 30 commits into from
Oct 29, 2020

Conversation

VassilIordanov
Copy link
Contributor

@VassilIordanov VassilIordanov commented Aug 5, 2020 •
edited
Loading

Release notes

Closes #3124
Closes #3123
Fixes #3245

User changes

  • users have a default search filter for status=ACTIVE, also active when no entity type is specified
  • common filters do not get reset while switching between search entity types
  • anet.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@VassilIordanov VassilIordanov changed the title Gh 3124 global status search Global status search Aug 5, 2020
@VassilIordanov VassilIordanov marked this pull request as draft August 5, 2020 01:00
github-actions[bot]
github-actions bot reviewed Aug 5, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShiftLeft Scan Summary

Tool Critical High Medium Low Status
ShiftLeft Source code analyzer for Python 0 0 0 0 ✅
ShiftLeft Security audit for Infrastructure 0 0 0 0 ✅
ShiftLeft Class file analyzer 1 10 0 0 ❌
ShiftLeft Source code analyzer for Java 0 0 0 0 ✅
ShiftLeft Source code analyzer for JavaScript 0 0 12 0 ❌
ShiftLeft Source code analyzer for SQL 0 0 0 0 ✅
ShiftLeft Shell script analysis 0 0 0 0 ✅

Recommendation

Please review the findings from your Code scanning alerts before approving this pull request 👍

@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2020

This pull request introduces 12 alerts and fixes 1 when merging 88c54d5 into 217d241 - view on LGTM.com

new alerts:

  • 12 for Missing Override annotation

fixed alerts:

  • 1 for No clone method

github-actions[bot]
github-actions bot reviewed Aug 5, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShiftLeft Scan Summary

Tool Critical High Medium Low Status
ShiftLeft Source code analyzer for Python 0 0 0 0 ✅
ShiftLeft Security audit for Infrastructure 0 0 0 0 ✅
ShiftLeft Class file analyzer 1 10 0 0 ❌
ShiftLeft Secrets audit 0 2 0 0 ✅
ShiftLeft Source code analyzer for Java 0 0 0 0 ✅
ShiftLeft Source code analyzer for JavaScript 0 0 12 0 ❌
ShiftLeft Source code analyzer for SQL 0 0 0 0 ✅
ShiftLeft Shell script analysis 0 0 0 0 ✅

Recommendation

Please review the findings from your Code scanning alerts before approving this pull request 👍

@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2020

This pull request introduces 12 alerts and fixes 1 when merging 41e5805 into 217d241 - view on LGTM.com

new alerts:

  • 12 for Missing Override annotation

fixed alerts:

  • 1 for No clone method

github-actions[bot]
github-actions bot reviewed Aug 5, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShiftLeft Scan Summary

Tool Critical High Medium Low Status
ShiftLeft Source code analyzer for Python 0 0 0 0 ✅
ShiftLeft Security audit for Infrastructure 0 0 0 0 ✅
ShiftLeft Class file analyzer 1 10 0 0 ❌
ShiftLeft Secrets audit 0 2 0 0 ✅
ShiftLeft Source code analyzer for Java 0 0 0 0 ✅
ShiftLeft Source code analyzer for JavaScript 0 0 12 0 ❌
ShiftLeft Source code analyzer for SQL 0 0 0 0 ✅
ShiftLeft Shell script analysis 0 0 0 0 ✅

Recommendation

Please review the findings from your Code scanning alerts before approving this pull request 👍

@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2020

This pull request introduces 12 alerts and fixes 1 when merging 8cb78bc into 217d241 - view on LGTM.com

new alerts:

  • 12 for Missing Override annotation

fixed alerts:

  • 1 for No clone method

@VassilIordanov VassilIordanov force-pushed the GH-3124-global-status-search branch from 8cb78bc to 127af65 Compare August 5, 2020 04:55
@VassilIordanov VassilIordanov marked this pull request as ready for review August 5, 2020 05:01
github-actions[bot]
github-actions bot reviewed Aug 5, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShiftLeft Scan Summary

Tool Critical High Medium Low Status
ShiftLeft Source code analyzer for Python 0 0 0 0 ✅
ShiftLeft Security audit for Infrastructure 0 0 0 0 ✅
ShiftLeft Class file analyzer 1 10 0 0 ❌
ShiftLeft Secrets audit 0 2 0 0 ✅
ShiftLeft Source code analyzer for Java 0 0 0 0 ✅
ShiftLeft Source code analyzer for JavaScript 0 0 12 0 ❌
ShiftLeft Source code analyzer for SQL 0 0 0 0 ✅
ShiftLeft Shell script analysis 0 0 0 0 ✅

Recommendation

Please review the findings from your Code scanning alerts before approving this pull request 👍

@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2020

This pull request fixes 1 alert when merging 127af65 into 217d241 - view on LGTM.com

fixed alerts:

  • 1 for No clone method

@gjvoosten
#3124: Fix migration
98d52b6 
Make sure migration has a unique name.
Properly quote camelCased columns.
Use correct boolean type depending on database.
Remove text seemingly pasted at random.
@gjvoosten
#3124: Remove unused import
888a499
@gjvoosten
#3124: Fix equals method
4407bc6
@gjvoosten
#3124: Add missing customFields to hashCode
86a1054
@VassilIordanov
Merge branch 'candidate' of https://github.com/NCI-Agency/anet into G…
0d15f20 
…H-3124-global-status-search
@VassilIordanov
#3124: Default to domain username before uuid when a Person's name is…
7cf6499 
… not present

Also, make AnetDevAuthenticator behave the same as AnetAuthenticationFilter - by not setting the domain username as name
@VassilIordanov
#3124: Filter out People pending verification from position assignmen…
d8f6ce9 
…ts and report attendance selection UIs
@VassilIordanov
#3124: Fix broken test after merge
807a513
@lgtm-com
Copy link

lgtm-com bot commented Sep 1, 2020

This pull request fixes 3 alerts when merging 807a513 into f3ca1cf - view on LGTM.com

fixed alerts:

  • 3 for No clone method

@gjvoosten gjvoosten dismissed their stale review September 3, 2020 08:04

ShiftLeft reports stale issues, nothing we can do about it.

@gjvoosten gjvoosten removed their request for review September 3, 2020 08:04
gjvoosten
gjvoosten requested changes Sep 28, 2020
View reviewed changes
Copy link
Collaborator

@gjvoosten gjvoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description has the box checked for: "Added and/or updated e2e tests", but there appear to be no changes to the e2e tests. Please add some client-side tests.

@lgtm-com
Copy link

lgtm-com bot commented Oct 6, 2020

This pull request fixes 3 alerts when merging 2fed218 into 8ee8b8c - view on LGTM.com

fixed alerts:

  • 3 for No clone method

@gjvoosten
Merge branch 'candidate' into GH-3124-global-status-search
0b3c03d
@gjvoosten
#3245: Only show people not pending verification
aec6419 
Fixes #3245
@gjvoosten
#3124: Consistently use Model.STATUS everywhere
e093636
@gjvoosten
Also prevent browser navigation when not going to the search page
f131b5f 
Apply the fix from commit 495b9a2 to all cases.
@gjvoosten
Reinstate search icon behaviour
7a11253 
Hide/show the 'simple' search icon (magnifying glass) when the advanced search popup is shown/hidden.
Reinstates behaviour that was removed as part of commit ba70261 .
@gjvoosten
#3124: Also fill in lastName
2ba4c30 
Required since commit 7cf6499 .
@gjvoosten gjvoosten force-pushed the GH-3124-global-status-search branch from 65ae14a to 2ba4c30 Compare October 20, 2020 09:09
cemalettin-work
cemalettin-work reviewed Oct 20, 2020
View reviewed changes
client/src/components/AdvancedSearch.js
setFilters([])
setFilters(
filters.filter(value => commonFiltersForAllObjectTypes[value.key])
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered the solution where we keep filter types which are common between previous object type and next object type? For example:

  • I have "People" object toggled, i selected "Location", "Organization", "Status" filters. (Which are also in the "Position" object)
  • I click "Position" toggle button. "Location" and "Organization" is gone, but "Status" is still there.
    We could keep all the common ones between switching object types.

@gjvoosten gjvoosten mentioned this pull request Oct 27, 2020
Closed
@VassilIordanov VassilIordanov mentioned this pull request Oct 29, 2020
Closed
@VassilIordanov VassilIordanov merged commit f9e4106 into candidate Oct 29, 2020
@VassilIordanov VassilIordanov deleted the GH-3124-global-status-search branch October 29, 2020 07:29
cemalettin-work added a commit that referenced this pull request Nov 4, 2020
@cemalettin-work
Merge GH-3125-multiple-authors to GH-50-print-pdf
eeadddb
@cemalettin-work cemalettin-work mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@cemalettin-work cemalettin-work cemalettin-work approved these changes

@maradragan maradragan Awaiting requested review from maradragan

@bssimsoft bssimsoft Awaiting requested review from bssimsoft

@oayvazoglusim oayvazoglusim Awaiting requested review from oayvazoglusim

@sahindoganlutfi sahindoganlutfi Awaiting requested review from sahindoganlutfi

@ysf-simsoft ysf-simsoft Awaiting requested review from ysf-simsoft

@gjvoosten gjvoosten Awaiting requested review from gjvoosten

Assignees

@oayvazoglusim oayvazoglusim

@ysf-simsoft ysf-simsoft

Labels
enhancement
Projects
None yet
Milestone
No milestone
6 participants
@VassilIordanov @gjvoosten @maradragan @cemalettin-work @oayvazoglusim @ysf-simsoft