Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default global filter for status in search #3124

Closed
VassilIordanov opened this issue Aug 4, 2020 · 1 comment · Fixed by #3125
Closed

Default global filter for status in search #3124

VassilIordanov opened this issue Aug 4, 2020 · 1 comment · Fixed by #3125
Assignees
@VassilIordanov
Labels
enhancement

Comments

@VassilIordanov
Copy link
Contributor

VassilIordanov commented Aug 4, 2020 •
edited
Loading

When users type a search text to search for something, the search finds both active and inactive items. The default path should be to see only active items, unless explicitly specified.

It would be more intuitive to have a default search filter present, which is for status=active. If the user wants to see anything beyond that, they can either explicitly remove the filter, or specify a different value for status.

The issue is that not all search types have an status attribute, and one of them (People) has 3 different values:
Report - no status attribute
People - status is one of ACTIVE, INACTIVE, NEW_USER
all others - status is one of ACTIVE, INACTIVE

One solution is to make:
Report - no status attribute
all others, including people - status is one of ACTIVE, INACTIVE
People - use pendingVerification instead for deriving NEW_USER state

Subsequently, we can add a global filter for status (with a UI default of ACTIVE), and (for now) with no effect on reports. Alternatively, we could make it equivalent to state=PUBLISHED for reports
@VassilIordanov VassilIordanov self-assigned this Aug 4, 2020
@VassilIordanov VassilIordanov changed the title Default filters for search Default global filter for status in search Aug 4, 2020
VassilIordanov added a commit that referenced this issue Aug 5, 2020
@VassilIordanov
#3124: Replace People status of NEW_USER with pendingVerification
0485576
VassilIordanov added a commit that referenced this issue Aug 5, 2020
@VassilIordanov
#3124: Abtract status through all object and query types
88c54d5
VassilIordanov added a commit that referenced this issue Aug 5, 2020
@VassilIordanov
#3124: Query filters UI to work with common filters
41e5805
VassilIordanov added a commit that referenced this issue Aug 5, 2020
@VassilIordanov
#3124: Set status=active as the default query parameter
8cb78bc
@VassilIordanov VassilIordanov mentioned this issue Aug 5, 2020
Merged
14 tasks
VassilIordanov added a commit that referenced this issue Aug 5, 2020
@VassilIordanov
#3124: Abtract status through all object and query types
1b0dcce
VassilIordanov added a commit that referenced this issue Aug 5, 2020
@VassilIordanov
#3124: Query filters UI to work with common filters
faa5b8d
VassilIordanov added a commit that referenced this issue Aug 5, 2020
@VassilIordanov
#3124: Set status=active as the default query parameter
127af65
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Fix migration
98d52b6 
Make sure migration has a unique name.
Properly quote camelCased columns.
Use correct boolean type depending on database.
Remove text seemingly pasted at random.
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Remove unused import
888a499
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Fix equals method
4407bc6
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Add missing customFields to hashCode
86a1054
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Add missing status to equals and hashCode
2281d4e
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Remove unnecessary implements
d3df4db
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Remove duplicate status from equals
85710f2 
Field is already in super.equals.
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Add missing clone methods
548bdf2 
These search query beans are used in batching and have non-primitive fields that need to be cloned.
VassilIordanov added a commit that referenced this issue Aug 5, 2020
@VassilIordanov
#3124: Report searcher to use query state
89e9613
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Add missing pendingVerification
4c95ea1
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Status for person search query is now a simple field
380cf37 
It is no longer an array, as the NEW_USER choice is gone, so having multiple values is pointless.
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Use the model-instance specific status
bf94f51
gjvoosten pushed a commit that referenced this issue Aug 5, 2020
@VassilIordanov @gjvoosten
#3124: Report searcher to use query state
59fe405
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Add missing pendingVerification
6f2f2b1
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Status for person search query is now a simple field
d8c23ba 
It is no longer an array, as the NEW_USER choice is gone, so having multiple values is pointless.
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Use the model-instance specific status
506fb71
gjvoosten added a commit that referenced this issue Aug 5, 2020
@gjvoosten
#3124: Add test that there are no INACTIVE reports
758f545
@dspCarlson
Copy link

Implemented in release 2.1.27-285 on 11 August 2020. Closing the ticket.

VassilIordanov added a commit that referenced this issue Aug 18, 2020
@VassilIordanov
Merge branch 'GH-3124-global-status-search' of https://github.com/NCI…
608599d 
…-Agency/anet into staging
VassilIordanov added a commit that referenced this issue Sep 1, 2020
@VassilIordanov
Merge branch 'candidate' of https://github.com/NCI-Agency/anet into G…
0d15f20 
…H-3124-global-status-search
VassilIordanov added a commit that referenced this issue Sep 1, 2020
@VassilIordanov
#3124: Default to domain username before uuid when a Person's name is…
7cf6499 
… not present

Also, make AnetDevAuthenticator behave the same as AnetAuthenticationFilter - by not setting the domain username as name
VassilIordanov added a commit that referenced this issue Sep 1, 2020
@VassilIordanov
#3124: Filter out People pending verification from position assignmen…
d8f6ce9 
…ts and report attendance selection UIs
VassilIordanov added a commit that referenced this issue Sep 1, 2020
@VassilIordanov
#3124: Fix broken test after merge
807a513
VassilIordanov added a commit that referenced this issue Oct 6, 2020
@VassilIordanov
Merge branch 'candidate' of https://github.com/NCI-Agency/anet into G…
2fed218 
…H-3124-global-status-search
gjvoosten added a commit that referenced this issue Oct 20, 2020
@gjvoosten
Merge branch 'candidate' into GH-3124-global-status-search
0b3c03d
gjvoosten added a commit that referenced this issue Oct 20, 2020
@gjvoosten
#3124: Consistently use Model.STATUS everywhere
e093636
gjvoosten added a commit that referenced this issue Oct 20, 2020
@gjvoosten
#3124: Also fill in lastName
65ae14a 
Required since commit 7cf6499 .
gjvoosten added a commit that referenced this issue Oct 20, 2020
@gjvoosten
#3124: Also fill in lastName
2ba4c30 
Required since commit 7cf6499 .
gjvoosten pushed a commit that referenced this issue Oct 27, 2020
Merge branch 'candidate' into GH-3124-global-status-search
fc2b1b2
@VassilIordanov VassilIordanov mentioned this issue Oct 29, 2020
Closed
VassilIordanov added a commit that referenced this issue Oct 29, 2020
@VassilIordanov
Merge pull request #3125 from NCI-Agency/GH-3124-global-status-search
f9e4106 
Global status search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VassilIordanov VassilIordanov

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Global status search NCI-Agency/anet
2 participants
@dspCarlson @VassilIordanov