Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error messaging in sfcsub.F to conform to NCEP/NCO standards #628

Closed
wants to merge 3 commits into from
Closed

Update error messaging in sfcsub.F to conform to NCEP/NCO standards #628

wants to merge 3 commits into from

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

Error messages updated. Function of code was not changed.

Fixes #625

@GeorgeGayno-NOAA
Copy link
Collaborator Author

What official testing is required before merging?

@climbfuji
Copy link
Collaborator

What official testing is required before merging?

A ton. We have to add this to the ufs-weather-model commit queue (with corresponding PRs in fv3atm and ufs-weather-model to handle the submodule pointer updates), run regression tests on all tier-1 platforms and CI tests. You don't need to worry, since your PR is so small I will combine it with other changes and handle the submodule pointer updates.

Note however that the CCPP rules do not allow writing to stdout/stderr directly. Instead, an error message needs to be populated with the corresponding information, an error flag set to 1 and the code needs to return. The CCPP framework then escalated this to the host model, which writes out the error message and aborts.

Making this change is beyond the purpose of this PR, but it is important that we work towards this capability in he future. It needs to work with UFS_UTILS and at the same time be in compliance with NCO error reporting standards.

@GeorgeGayno-NOAA
Copy link
Collaborator Author

This update has been absorbed by PR #641. Closing.

@climbfuji
Copy link
Collaborator

For future reference, no need to close. Since all your commits are included in #641, your PR should get flagged as "merged" automatically when #641 is merged.

climbfuji added a commit that referenced this pull request Apr 28, 2021
Collect PRs #613, #628, #634, #635 / update long names and vertical dimension for atmosphere_heat_diffusivity and atmosphere_momentum_diffusivity
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the feature/sfcsub_errmsg branch August 23, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error messaging in sfcsub.F
2 participants