fix bug in UGWPv0 and v1 #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
grantfirl
commented
Apr 9, 2021
•
grantfirl
commented
- fix bug in UGWPv0 where it was using the wrong arguments in a oro_wam_2017() call
- also cires_orowam2017.F90 appears to be a duplicate and is not used by any scheme
- fix bug in UGWPv1 where it was using the wrong arguments in a oro_spectral_solver() call
…_2017() call; also cires_orowam2017.F90 appears to be a duplicate and is not used by any scheme
grantfirl
requested review from
climbfuji,
JulieSchramm and
llpcarson
as code owners
… intel/debug build
|
This has only been tested on Cheyenne/Intel with debug mode using the SCM build system, where the problem was discovered by @JulieSchramm . |
JulieSchramm
approved these changes
Apr 12, 2021
HelinWei-NOAA
pushed a commit
to HelinWei-NOAA/ccpp-physics
that referenced
this pull request
Feb 26, 2023
…#613) * Hardcoded coarse terrain for moving nest with terrain_smoother=4 * Update HAFSv1 CCPP suites to use the unified ugwp scheme. * Update submodule upp. * Removed debug print statements for terrain_smoother * Fixed bug in calculation of nest halo weights identified by Biju Thomas in DDEBUG=ON builds. * Updated fix to moving nest weight calculations. * Use ind arrays for nest weight calculations. Ensures correct indexing. * Clean up for the fix of using ind arrays for moving-nest weight calculations (from @wramstrom). Co-authored-by: William Ramstrom <William.Ramstrom@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.