Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup constants in all physics #104

Closed
climbfuji opened this issue Jun 26, 2018 · 7 comments
Closed

Cleanup constants in all physics #104

climbfuji opened this issue Jun 26, 2018 · 7 comments

Comments

@climbfuji
Copy link
Collaborator

samfdeepcnv_run should get its various physical constants through the argument list as per CCPP requirements.
@grantfirl
Copy link
Collaborator

also samfshalcnv_run

@grantfirl grantfirl mentioned this issue Aug 2, 2018
Merged
@climbfuji climbfuji changed the title New scheme samfdeepcnv uses constants from physcons.f90 New schemes samfdeepcnv and gfdlmp use constants from physcons.F90 Aug 14, 2018
@climbfuji climbfuji changed the title New schemes samfdeepcnv and gfdlmp use constants from physcons.F90 New schemes samfdeepcnv, samfshalcnv_run and gfdlmp_{init,run} use constants from physcons.F90 Aug 14, 2018
@climbfuji
Copy link
Collaborator Author

also gfdlmp_{init,run}

@climbfuji
Copy link
Collaborator Author

this will also be true for the CAPS New Tiedtke physics scheme cu_ntiedtke.F90 (see PR #201)

@climbfuji climbfuji changed the title New schemes samfdeepcnv, samfshalcnv_run and gfdlmp_{init,run} use constants from physcons.F90 Cleanup constants in all physics Nov 18, 2019
@climbfuji
Copy link
Collaborator Author

This applies to many other physics schemes, someone should go through all of them and clean up. Push some common ones (rainmin, ...) to physcons.F90 and pass through argument list.

@climbfuji climbfuji mentioned this issue Nov 18, 2019
Closed
@climbfuji
Copy link
Collaborator Author

See also #245

@climbfuji
Copy link
Collaborator Author

See also #304 and #318.

Also, subroutines called by satmedmfvdif(q) use imported constants (the CCPP entry points do not).

@grantfirl grantfirl mentioned this issue Nov 20, 2019
Merged
@XiaSun-Atmos XiaSun-Atmos mentioned this issue Dec 7, 2020
Merged
This was referenced Jul 29, 2021
Merged
Merged
climbfuji pushed a commit to climbfuji/ccpp-physics that referenced this issue Sep 8, 2021
@DomHeinzeller
Merge pull request NCAR#104 from climbfuji/update_gsl_develop_from_ma…
1263361 
…in_20210819

Update gsl/develop from main 2021/08/24
@climbfuji
Copy link
Collaborator Author

This catch-all issue for importing constants instead of passing them via the argument list doesn't help. There are many issues related to this problem on a per-scheme basis, which makes more sense.

hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this issue Aug 3, 2022
@junwang-noaa @jswhit2
@JongilHan66 @DomHeinzeller @grantfirl @climbfuji @DeniseWorthen
Chsp physics update, global latlon grid, post changes and CCN-IN foll…
bc9aa3b 
…owup bugfix (NCAR#104)

* point to ccpp branch chsp_latlon_post

* add chsp code changes from Jongil

Co-authored-by: Jongil Han <jingil.han@noaa.gov>

* add landsfcmdl variable to model sfc history file meta data

* add global latlon grid on write grid component, code changes from Jeffrey Whitaker

Co-authored-by: Jeffrey Whitaker <Jeffrey.S.Whitaker@noaa.gov>

* add chsp code changes in ccpp-physics

Co-authored-by: Jongil Han <jongil.han@noaa.gov>

* remove support for legacy Intel compilers in CCPP gmake build

Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov>

* update ccpp physics, fix syntax error

* update sflx.f in ccpp physics

* CCN-IN followup bugfix

Co-authored-by: Grant Firl <grantf@ucar.edu>

* Bugfix for GNU compiler in io/module_wrt_grid_comp.F90; bugfix in gfsphysics/physics/sfc_diff.f; updates for CCPP

* merge fv3 dycore ccpp framework and physics to the latest repoes

* cmeps integration changes

Co-authored-by: Denise Worthen <Denise.Worthen@noaa.gov>

* update CCPP with tsfcl change

* fix timestr in module_cap_cpl.F90

* fix syntax error in ugwp_driver_v0.F

* point ccpp/physics back to NCAR master

Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
Co-authored-by: Jeffrey Whitaker <Jeffrey.S.Whitaker@noaa.gov>
Co-authored-by: Jongil Han <jongil.han@noaa.gov>
Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov>
Co-authored-by: Grant Firl <grantf@ucar.edu>
Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
Co-authored-by: Denise Worthen <Denise.Worthen@noaa.gov>
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this issue Aug 3, 2022
@DomHeinzeller
Merge pull request NCAR#104 from climbfuji/GF_RadiationUpdate_RevertA…
9beb0f9 
…erosols

Gf radiation update revert aerosols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@climbfuji @grantfirl