Cleanup grandfathered-in constants in CCPP - round 1 #726
Conversation
climbfuji
added
No Baseline Change
climbfuji
added
Baseline Updates
…r-model into cleanup_grandfathered_constants_20210729
climbfuji
changed the title
|
CI tests failed, because the CI tests use old suite definition files that are no longer in use by any of the regression tests and that are removed as part of my commits: We will need to update the CI tests to use suite definition files that are relevant for the current code base. |
|
Machine: cheyenne |
climbfuji
changed the title
|
Machine: orion |
…thub.com/climbfuji/ufs-weather-model into cleanup_grandfathered_constants_20210729
|
Machine: orion |
…thub.com/climbfuji/ufs-weather-model into cleanup_grandfathered_constants_20210729
climbfuji
added
the
Ready for Commit Queue
|
@DusanJovic-NOAA ready for commit - fv3atm submodule pointer is updated and correct. Thanks! |
…X) (#726) * Grid-stat and point-stat run scripts. * Stand-alone scripts for verification. * Added comments to gridvx scripts. * Added qsub_job.sh and added comments to provide context on running Vx.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
[n/a] If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
This PR updates the submodule pointer for fv3atm and ccpp-physics for the changes described in the associated PRs below. The motivation behind these changes is that physical parameterizations should receive constants (e.g. gravitational acceleration) from the host model via the argument list instead of importing them from some Fortran module or defining them locally. This ensures consistency and enhances interoperability.
The changes in ccpp-physics lead to different answers for the two tests
control_csawmgandcontrol_csawmgtwith Intel in PROD mode. With GNU (PROD, DEBUG) and with Intel in DEBUG mode, the results are identical with the previous baseline, thus a consequence of the optimization.Issue(s) addressed
These PRs are a step towards resolving issues NCAR/ccpp-physics#104 and NCAR/ccpp-physics#245.
Testing
Regression tests were run against the existing baselines on July 29, 2021, on Gaea/Intel. All tests passed.
[RegressionTests_gaea.intel.log](https://github.com/ufs-community/ufs-weather-model/files/6904027/RegressionTests_gaea.intel.log
Final regression testing:
Dependencies
NCAR/ccpp-physics#525
NOAA-EMC/fv3atm#360
#726