Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoahMP uses internal constants rather than those provided from host #318

Closed
grantfirl opened this issue Sep 13, 2019 · 1 comment
Closed

NoahMP uses internal constants rather than those provided from host #318

grantfirl opened this issue Sep 13, 2019 · 1 comment

Comments

@grantfirl
Copy link
Collaborator

grantfirl commented Sep 13, 2019 •
edited
Loading

Like for UGWP, physical constants are defined locally internally to NoahMP rather than used from the host model, despite being passed in through the driving routine through the CCPP. Fixing this will "change the answer" and therefore was not done during the initial CCPP transition. This is related to issue #304 and PR #305.
@grantfirl grantfirl mentioned this issue Sep 13, 2019
Merged
@climbfuji climbfuji mentioned this issue Nov 18, 2019
Closed
@climbfuji
Copy link
Collaborator

This is a duplicate of #582, closing.

hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this issue Aug 3, 2022
@DusanJovic-NOAA @junwang-noaa
Move IO related configuration from fv3_cap to write grid component. A…
8384673 
…dd cice6 ice albedo (NCAR#318)

* Move IO related configuration from fv3_cap to write grid component
* Move some module variables that are not public, nor shared between various subroutines to local scope.
* Consolidate three versions of string buffers (for logging) into one (msgString)
* Remove unused variables (fcstmype for example)
* Rename atmos_model_finalize to ModelFinalize, for consistency
* Move restart_interval,num_restart_interval and frestart to module_fcst_grid_comp
* Get cice6 ice albedo to FV3

Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@climbfuji @grantfirl