Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Boilerplate: Rename LayoutContainer to AppContainer #444

Closed
MoOx opened this issue May 5, 2016 · 5 comments · Fixed by #698
Closed

Boilerplate: Rename LayoutContainer to AppContainer #444

MoOx opened this issue May 5, 2016 · 5 comments · Fixed by #698
Labels
discussion enhancement

Comments

@MoOx
Copy link
Owner

MoOx commented May 5, 2016

Following https://twitter.com/MoOx/status/728210032093990912
@DavidWells
Copy link
Contributor

👍 I agree

@MoOx MoOx mentioned this issue May 17, 2016
Closed
@MoOx
Copy link
Owner Author

MoOx commented Aug 24, 2016

@revolunet @thangngoc89 any thoughts on this?

@thangngoc89
Copy link
Contributor

This mightbe duplicated with react hot loader 3 if we go for that name.

@MoOx
Copy link
Owner Author

MoOx commented Aug 24, 2016

we will use rhl3 appcontainer so people don't have to ;)

@MoOx MoOx mentioned this issue Aug 24, 2016
Closed
@thangngoc89
Copy link
Contributor

Ok. If so, that name is fine to me

This was referenced Aug 31, 2016
Closed
Merged
MoOx added a commit that referenced this issue Sep 1, 2016
@MoOx
Changed(phenomic-theme-base): new default file tree
21a9ce8 
We encourage you to update to a similar structure if you were using the
previous one.
Main changes:

  - ``web_modules/layouts`` => ``src/layouts``
  - ``web_modules/{Components}`` => ``src/components/*``
  - ``web_modules/app/*`` => ``src/*``
  - ``web_modules/LayoutContainer`` => ``src/AppContainer.js``

Closes #529
Closes #444
MoOx added a commit that referenced this issue Sep 1, 2016
@MoOx
Changed(phenomic-theme-base): new default file tree
4ca9211 
We encourage you to update to a similar structure if you were using the
previous one.
Main changes:

  - ``web_modules/layouts`` => ``src/layouts``
  - ``web_modules/{Components}`` => ``src/components/*``
  - ``web_modules/app/*`` => ``src/*``
  - ``web_modules/LayoutContainer`` => ``src/AppContainer.js``

Closes #529
Closes #444
@MoOx MoOx closed this as completed in #698 Sep 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
discussion enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update boilerplate to be a base theme MoOx/phenomic
3 participants
@MoOx @DavidWells @thangngoc89