Update boilerplate to be a base theme #698
Conversation
|
So far so good, I didn't see any different from this and the old boilerplate. Am I right ? Just out of curiosity, do you have plan to let user swap out compatible theme with 1 line of config ? |
You probably didn't look enough. There are a lot of noticeable differences if you look at the tree.
On the long run yes, but for now we are far from that (maybe not that far but still). |
MoOx
force-pushed
the
feat.prepare-theme-base
branch
from
44000f6
to
1d4f64f
Compare
MoOx
changed the title
|
PR updated. Should be good now. |
|
|
||
| render() { | ||
| return ( | ||
| <div className={ styles.container }> |
There was a problem hiding this comment.
I think this is unnecessary, can we just move the styling part to AppContainer ?
There was a problem hiding this comment.
This is to keep a simple AppContainer without any CSS.
|
Except for my comments. LGTM |
We encourage you to update to a similar structure if you were using the
previous one.
Main changes:
- ``web_modules/layouts`` => ``src/layouts``
- ``web_modules/{Components}`` => ``src/components/*``
- ``web_modules/app/*`` => ``src/*``
- ``web_modules/LayoutContainer`` => ``src/AppContainer.js``
Closes #529
Closes #444
To prevent issue in the future, is now accessible by doing
``import { PageContainer } from "phenomic"``.
If you want to import it with a different name, you can do it this way:
```js
import { PageContainer as PhenomicPageContainer } from "phenomic"
```
…iv>`` if a single string is passed as a child.
MoOx
force-pushed
the
feat.prepare-theme-base
branch
from
bd1ded5
to
19b21e8
Compare
Closes #529
Closes #444
Will closes #433