-
Notifications
You must be signed in to change notification settings - Fork 249
Add support for themes and inheritance #508
Comments
I like it. 👍 It would also be a good chance to solidify how 'themes' are made. For instance, all wordpress themes have a This visual representation is also a handy reference: https://developer.wordpress.org/themes/basics/template-hierarchy/#visual-overview. Not to say that phenomic would need to support everything under the sun but a "standard" way of doing things would be helpful. I think wordpress did a lot of things right in how they standardized their theming over the years |
Just an idea on "standardized template". Interested in thoughts =)
The idea behind the The idea behind the If site wants to switch out the theme, they would just need a find/replace to swap out
The idea behind |
Any thoughts on this? Starting to build a new site and wanted to try and head in this direction |
You proposal is ok.
|
The theme/plugins used will be specified in phenomic config |
is the idea that Or is |
We can discuss about that :)
|
Ok going to push forward on building the site with this kind of outline. We are going to open source it as well. Let me know if you want to jump on a call to chat about it. I'm curious to see how you see the theming work =) |
I already implemented something similar for my previous static engine. The idea is to have a kind of php include_path and reference to files/layouts etc will look in this order
Should be really easy to handle via webpack resolve option. |
@MoOx checkout https://github.com/serverless/site/tree/master/src and let me know what you think. Getting close to a pretty standard structure that (I think) is easy to approach for folks not used to My team at serverless was able to jump in and start making tweaks pretty easily |
@DavidWells Thanks for sharing your architecture. The fun part is that I am currently working on that and I almost have the same tree (probably because we discussed about this):
I will borrow you some interesting stuff like "pages" and the fact that you add README in every folder. I will also move app/* into src directly. The IndexComponent is interesting. LayoutContainer is definitely confusing. Currently I am using AppContainer according to #444. What do you think about this name? |
big nope for me 😄 |
At some point you need to have this thing. Pretty sure it's not that hard to handle. And it's kind of a killer feature we can't miss. |
how do you consider themes in a react app where modules are static? |
As discussed yesterday we should at least provides this
Inheritance is tricky and not easy to handle. |
We will see that later, not a priority for v1. |
Here is what I have in mind, inspired by how Wordpress handle themes:
We have to think a little bit more about that, so people can easily "add" things, not just overwrite (eg: add/merge webpack config/loaders etc?)
This is just an idea, and must be discussed and enhanced :)
The text was updated successfully, but these errors were encountered: