Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof_verified: of_int should raise Invalid_argument not a Failure. #14206

Closed
dannywillems opened this issue Sep 25, 2023 · 1 comment · Fixed by #14216
Closed

Proof_verified: of_int should raise Invalid_argument not a Failure. #14206

dannywillems opened this issue Sep 25, 2023 · 1 comment · Fixed by #14216
Assignees
@volhovm

Comments

@dannywillems
Copy link
Member 

          ```suggestion

(** [of_int n] converts the runtime natural [n] to the data type natural.
@raise Failure if the value [n] is above or equal to 3 *)

Should be `Invalid_argument` too.

_Originally posted by @rbonichon in https://github.com/MinaProtocol/mina/pull/13386#discussion_r1336273566_
@dannywillems dannywillems mentioned this issue Sep 25, 2023
Merged
@dannywillems
Copy link
Member Author

It should also be renamed in of_int_exn to follow conventions.

volhovm added a commit that referenced this issue Sep 26, 2023
@volhovm
[#14206,#14205] Cosmetics for of_int, of_nat
0fc6e31
@volhovm volhovm mentioned this issue Sep 26, 2023
Closed
7 tasks
@volhovm volhovm self-assigned this Sep 26, 2023
volhovm added a commit that referenced this issue Sep 26, 2023
@volhovm
[#14206,#14205] Cosmetics for of_int, of_nat
934d05d
@volhovm volhovm mentioned this issue Sep 26, 2023
Merged
volhovm added a commit that referenced this issue Oct 12, 2023
@volhovm
[#14206,#14205] Cosmetics for of_int, of_nat
5ea51e2
volhovm added a commit that referenced this issue Oct 17, 2023
@volhovm
[#14206,#14205] Cosmetics for of_int, of_nat
8e00c56
volhovm added a commit that referenced this issue Oct 31, 2023
@volhovm
[#14206,#14205] Cosmetics for of_int, of_nat
ff3f95c
volhovm added a commit that referenced this issue Nov 1, 2023
@volhovm
Merge pull request #14216 from MinaProtocol/volhovm/14206-14206-of_in…
9cdd592 
…t-of_nat

[#14206,#14205] Cosmetics for of_int, of_nat
@mitschabaude mitschabaude mentioned this issue Nov 28, 2023
Closed
@mitschabaude mitschabaude mentioned this issue Dec 19, 2023
Closed
@mitschabaude mitschabaude mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volhovm volhovm

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@volhovm @dannywillems