Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#14206,#14205] Cosmetics for of_int, of_nat #14214

Closed
wants to merge 1 commit into from

Conversation

volhovm
Copy link
Member

@volhovm volhovm commented Sep 26, 2023

Explain your changes:

  • Both of_int and of_nat are now raising Invalid_argument instead of failwithf
  • They are also renamed to of_int_exn and of_nat_exn

Explain how you tested your changes:

  • Not tested explicitly

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@volhovm volhovm requested a review from a team as a code owner September 26, 2023 10:52
@volhovm volhovm force-pushed the volhovm/#14206-#14205-of_int_nat branch from 0fc6e31 to 934d05d Compare September 26, 2023 11:20
@volhovm
Copy link
Member Author

volhovm commented Sep 26, 2023

!ci-build-me

@volhovm
Copy link
Member Author

volhovm commented Sep 26, 2023

Closing this PR since branch name with hashes # kills the CI. Will reopen with a different branch name.

@volhovm volhovm closed this Sep 26, 2023
@volhovm volhovm deleted the volhovm/#14206-#14205-of_int_nat branch September 26, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proof_verified: of_int should raise Invalid_argument not a Failure.
1 participant