Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#14206,#14205] Cosmetics for of_int, of_nat #14216

Merged
merged 2 commits into from
Nov 1, 2023
Merged

[#14206,#14205] Cosmetics for of_int, of_nat #14216

merged 2 commits into from
Nov 1, 2023

Conversation

volhovm
Copy link
Member

@volhovm volhovm commented Sep 26, 2023 •
edited
Loading

Explain your changes:

@volhovm volhovm requested a review from a team as a code owner September 26, 2023 11:57
@volhovm
Copy link
Member Author

volhovm commented Sep 26, 2023

!ci-build-me

rbonichon
rbonichon approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@rbonichon rbonichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - need to update o1js-bindings (and thus o1js too) for this to pass CI

@volhovm volhovm mentioned this pull request Sep 26, 2023
Closed
This was referenced Oct 12, 2023
Merged
Merged
@volhovm volhovm requested a review from a team as a code owner October 12, 2023 12:27
@volhovm volhovm force-pushed the volhovm/14206-14206-of_int-of_nat branch from c8670fa to 421e446 Compare October 12, 2023 12:29
@volhovm
Copy link
Member Author

volhovm commented Oct 12, 2023

!ci-build-me

@dannywillems
Copy link
Member

LGTM. Note that we also update the bindings in o1js from time to time using npm run bindings in o1js.

@volhovm volhovm force-pushed the volhovm/14206-14206-of_int-of_nat branch from 421e446 to 71ad063 Compare October 17, 2023 14:47
@volhovm volhovm force-pushed the volhovm/14206-14206-of_int-of_nat branch from 71ad063 to 871f29c Compare October 31, 2023 23:00
@volhovm
Copy link
Member Author

volhovm commented Nov 1, 2023

!ci-build-me

@volhovm volhovm merged commit 9cdd592 into develop Nov 1, 2023
2 checks passed
@volhovm volhovm deleted the volhovm/14206-14206-of_int-of_nat branch November 1, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

@dannywillems dannywillems dannywillems approved these changes

@rbonichon rbonichon rbonichon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proof_verified: of_int should raise Invalid_argument not a Failure.
4 participants
@volhovm @dannywillems @rbonichon @mitschabaude