Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick: test: fix wallet test (#7966) #7970

Merged
merged 1 commit into from
Dec 1, 2023
Merged

chore: cherry-pick: test: fix wallet test (#7966) #7970

merged 1 commit into from
Dec 1, 2023

Conversation

chrisleewilcox
Copy link
Contributor

Description

The purpose of this PR is to address the failing wallet-tests.spec. The test was failing because of a token that no longer appears in the auto complete search. Feel free to read up more on this via: https://consensys.slack.com/archives/C02U025CVU4/p1701360559491539

Related issues

Fixes: #

Manual testing steps

  1. Go to this page... 2.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko @chrisleewilcox
test: fix wallet test (#7966)
a91f558 
## **Description**

The purpose of this PR is to address the failing wallet-tests.spec. The
test was failing because of a token that no longer appears in the auto
complete search. Feel free to read up more on this via:
https://consensys.slack.com/archives/C02U025CVU4/p1701360559491539


## **Related issues**

Fixes: #

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@chrisleewilcox chrisleewilcox added team-mobile-client release-7.12.0 Issue or pull request that will be included in release 7.12.0 labels Dec 1, 2023
@chrisleewilcox chrisleewilcox self-assigned this Dec 1, 2023
@chrisleewilcox chrisleewilcox marked this pull request as ready for review December 1, 2023 01:16
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner December 1, 2023 01:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f5b83f72-2135-4961-919c-db406efcd368
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/7.12.0@04d2d8d). Click here to learn what that means.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release/7.12.0    #7970   +/-   ##
=================================================
  Coverage                  ?   37.39%           
=================================================
  Files                     ?     1052           
  Lines                     ?    28173           
  Branches                  ?     2516           
=================================================
  Hits                      ?    10534           
  Misses                    ?    17040           
  Partials                  ?      599

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chrisleewilcox chrisleewilcox merged commit 24116b7 into release/7.12.0 Dec 1, 2023
30 checks passed
@chrisleewilcox chrisleewilcox deleted the chore/cherry-pick-7966 branch December 1, 2023 02:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

Assignees

@chrisleewilcox chrisleewilcox

Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisleewilcox @codecov-commenter @cortisiko @gauthierpetetin