Skip to content

Commit

Permalink
chore: cherry-pick: test: fix wallet test (#7966) (#7970)
Browse files Browse the repository at this point in the history
## **Description**

The purpose of this PR is to address the failing wallet-tests.spec. The
test was failing because of a token that no longer appears in the auto
complete search. Feel free to read up more on this via:
https://consensys.slack.com/archives/C02U025CVU4/p1701360559491539


## **Related issues**

Fixes: #

## **Manual testing steps**

1. Go to this page... 2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Curtis David <Curtis.David7@gmail.com>
  • Loading branch information
chrisleewilcox and cortisiko authored Dec 1, 2023
1 parent 04d2d8d commit 24116b7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions e2e/specs/wallet/wallet-tests.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,12 @@ describe(Smoke('Wallet Tests'), () => {
await ImportTokensView.tapImportButton();
await WalletView.isVisible();
await TestHelpers.delay(8000); // to prevent flakey behavior in bitrise
await WalletView.isTokenVisibleInWallet('0 XRP20');
await WalletView.isTokenVisibleInWallet('0 XRP');
});

it('should hide token from Wallet view', async () => {
await WalletView.removeTokenFromWallet('0 XRP20');
await WalletView.removeTokenFromWallet('0 XRP');
await TestHelpers.delay(1500);
await WalletView.tokenIsNotVisibleInWallet('0 XRP20');
await WalletView.tokenIsNotVisibleInWallet('XRP');
});
});

0 comments on commit 24116b7

Please sign in to comment.