-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix wallet test #7966
test: fix wallet test #7966
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7966 +/- ##
==========================================
+ Coverage 36.60% 36.66% +0.05%
==========================================
Files 1084 1090 +6
Lines 29075 29115 +40
Branches 2657 2668 +11
==========================================
+ Hits 10644 10674 +30
- Misses 17830 17835 +5
- Partials 601 606 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Missing release label release-7.12.3 on PR. Adding release label release-7.12.3 on PR and removing other release labels(release-7.13.0), as PR was added to branch 7.12.3 when release was cut. |
Description
The purpose of this PR is to address the failing wallet-tests.spec. The test was failing because of a token that no longer appears in the auto complete search. Feel free to read up more on this via: https://consensys.slack.com/archives/C02U025CVU4/p1701360559491539
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist