Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix wallet test #7966

Merged
merged 1 commit into from
Nov 30, 2023
Merged

test: fix wallet test #7966

merged 1 commit into from
Nov 30, 2023

Conversation

cortisiko
Copy link
Member

Description

The purpose of this PR is to address the failing wallet-tests.spec. The test was failing because of a token that no longer appears in the auto complete search. Feel free to read up more on this via: https://consensys.slack.com/archives/C02U025CVU4/p1701360559491539

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-client labels Nov 30, 2023
@cortisiko cortisiko requested a review from a team as a code owner November 30, 2023 21:57
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1922b5) 36.60% compared to head (e1ae798) 36.66%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7966      +/-   ##
==========================================
+ Coverage   36.60%   36.66%   +0.05%     
==========================================
  Files        1084     1090       +6     
  Lines       29075    29115      +40     
  Branches     2657     2668      +11     
==========================================
+ Hits        10644    10674      +30     
- Misses      17830    17835       +5     
- Partials      601      606       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit bbe9eeb into main Nov 30, 2023
32 checks passed
@cortisiko cortisiko deleted the detox/address-wallet-test-failure branch November 30, 2023 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 30, 2023
@gauthierpetetin gauthierpetetin added release-7.12.3 Issue or pull request that will be included in release 7.12.3 and removed release-7.13.0 Issue or pull request that will be included in release 7.13.0 labels Jan 2, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.12.3 on PR. Adding release label release-7.12.3 on PR and removing other release labels(release-7.13.0), as PR was added to branch 7.12.3 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.12.3 Issue or pull request that will be included in release 7.12.3 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants