Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove usage of bn.js v4 #12043

Draft
wants to merge 57 commits into
base: deps-ethereumjs-util-7
Choose a base branch
from
Draft

fix: remove usage of bn.js v4 #12043

wants to merge 57 commits into from
+408 −483

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 28, 2024 •
edited
Loading

Description

Replace use of bn.js@4 with bn.js@5.

Related issues

Blocked by

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Oct 28, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Oct 28, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@types/bn.js@5.1.5

View full report↗︎

@legobeat legobeat changed the title chore: remove usage of bn.js v4 fix: remove usage of bn.js v4 Oct 28, 2024
@legobeat legobeat force-pushed the bnjs5 branch 3 times, most recently from c19c4a9 to e00d162 Compare October 28, 2024 06:42
@legobeat
Copy link
Contributor Author

legobeat commented Oct 28, 2024 •
edited
Loading

Fun fact:

> (new BN4(NaN.toString())).toString(10)
'2423'

@legobeat legobeat force-pushed the bnjs5 branch 3 times, most recently from 9598284 to 7a8965c Compare October 28, 2024 08:02
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 28, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Oct 28, 2024
@MetaMask MetaMask deleted a comment from metamaskbot Oct 28, 2024
@legobeat legobeat force-pushed the bnjs5 branch 3 times, most recently from 2a07867 to 5473af5 Compare October 28, 2024 09:34
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 056a9aa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/04ef2eeb-efc1-45a4-872b-2be3b4c450f2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-ethereumjs-util-7 branch from 10bcec0 to 8f84b8d Compare October 28, 2024 10:41
@legobeat legobeat mentioned this pull request Oct 28, 2024
Open
@legobeat legobeat requested a review from a team October 29, 2024 06:35
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise type-bug Something isn't working and removed team-lavamoat Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2096f86
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e9b9f703-e490-442e-80f8-af2b5f8a53f3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
69.3% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat mentioned this pull request Oct 29, 2024
Open
@legobeat legobeat force-pushed the deps-ethereumjs-util-7 branch 3 times, most recently from 7818d3f to 7e3ed75 Compare October 29, 2024 19:48
@legobeat legobeat mentioned this pull request Nov 5, 2024
Open
@NicolasMassart NicolasMassart self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiniteflower infiniteflower Awaiting requested review from infiniteflower

Assignees

@NicolasMassart NicolasMassart

Labels
dependencies Pull requests that update a dependency file Run Smoke E2E Triggers smoke e2e on Bitrise team-security type-bug Something isn't working
Projects
PR review queue
Status: Needs more work from the author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @NicolasMassart